Re: [Demexp-dev] Debian package Camlrpc officially integrated

[Thomas Petazzoni]

Hello,

David MENTRE a écrit :

> I'm not sure to like this. Firstly, I suppose that demexp would thus
> rely on ocamlfind. Even if we need it for cduce, there is no real need
> for demexp core code. This argument can be discussed.

DemExp already rely on ocamlfind. The current Makefile uses it a lot :

CDUCEDIR:=$(shell ocamlfind query cduce)
PXPENGINEDIR:=$(shell ocamlfind query pxp-engine)
PXPLEXUTF8DIR:=$(shell ocamlfind query pxp-lex-utf8)
PCREDIR:=$(shell ocamlfind query pcre)
NETSTRINGDIR:=$(shell ocamlfind query netstring)
NETCLIENTDIR:=$(shell ocamlfind query netclient)
ULEXDIR:=$(shell ocamlfind query ulex)

The new way is much simpler :

COMMON_PACKAGES:=rpc str

SRV_PACKAGES:=cduce pxp-engine pxp-lex-utf8 pcre \
              netstring netclient ulex equeue threads num

CLNT_PACKAGES:=lablgtk2 lablgtk2.glade

 OCAMLOPT:=ocamlfind ocamlopt -linkpkg
 COMMON_OCAMLOPTFLAGS:=-package "$(COMMON_PACKAGES)" $(COMMON_OCAMLINC) 
-thread

 SRV_OCAMLOPTFLAGS:=-package "$(COMMON_PACKAGES)" -package 
"$(SRV_PACKAGES)" $(SRV_OCAMLINC) -I +camlp4 -thread

 CLNT_OCAMLOPTFLAGS:=-package "$(COMMON_PACKAGES)" -package 
"$(CLNT_PACKAGES)" $(CLNT_OCAMLINC) -I +lablgtk2

And that's it. Much simpler than a bunch of $(shell ocamlfind) and then 
a huge list of cmxa, and so on.

> Secondly, from a soft engineering point of view, is it so nice to hide
> dependencies? Wouldn't it make the Makefile less clear?

How do you know the depencies needed for CDuce ? Up to now, CDuce was 
compiled without Curl support, so it didn't require it. Now, it is 
compiled with Curl support in Debian. But in other distributions ? And 
with your own compiled version ?

Why not let the ocamlfind depency system handle the dependencies ?

Not using ocamlfind would mean that any modification of dependencies in 
any of the libraries used by DemExp would require a modification of 
DemExp Makefile.

Sincerly,

Thomas
--
PETAZZONI Thomas - address@hidden
http://thomas.enix.org - Jabber: address@hidden
KOS: http://kos.enix.org/ - SOS: http://sos.enix.org
Fingerprint : 0BE1 4CF3 CEA4 AC9D CC6E  1624 F653 CB30 98D3 F7A7

signature.asc
Description: OpenPGP digital signature