Re: [Demexp-dev] demexp web 2.0 compliance

[GISQUET Christophe]

Hello,

also please note that most of my previous mail was meant as a running joke 
coming from a comment from David about the Drupal page where he was 
mentionning adding a banner that was somewhat satirical regarding web 2.0.

David MENTRE a écrit :
> > that was used as a paradigm in the meta-service delivery to the
> > consumer^W voter.
>
> :-D Do you want to be part of our marketing team? ;-)

I think that with the addition of the above politically-correct paragraph, I
can qualify for that function. :-)

But of course I request truckloads of money or else people would think I'm
inefficient.

> In fact:
>
>  * The icon is colorful and nice;

You wouldn't blame you own creation, anyway :-)

>  * I like the idea of having distinct graphical layout for the official
>    and demo server. So your icon could be used for the demo server.

I wasn't aware of the icon mentioned below, and I really wanted to modify your
image so that to real fit in the web2.0 joke.

>  * I would prefer putting the icon into the misc/ directory, alongside
>    the "official" demexp logo (demexp.xpm). In fact, I would like to
>    have both your icon and the official one on Unix and Win32 platform;

"My" is a quite a stretch of what I've done to your banner.

>  * Could you rename demexp.ico into demexp-demo.ico?
>
>  * I would prefer that you rename gtk2-clnt/demexp.o into
>    gtk2-clnt/demexp-info.o or something like that;
>
>  * Shouldn't we put the demexp.rc into the win32/ directory? And rename
>    it demexp-info.rc (to be coherent with previous remark)?

All done.

>  * At mid term, it would be nice to generate content of demexp.rc from
>    content of demexp.nsi or another external file, in order to have a
>    coherent numbering scheme and other application info.

That would be hard. In fact, it would be simpler to do all through Makefile:
makensis has syntax "/D<symbol>=<value>" and windres (the tool to compile the 
.rc into binary data) has -D<symbol>=<value>

> Could you resubmit a patch? I could do it myself but I can't check that
> it works. If no let me know and I'll make the modifications myself.

Patch generated with "hg diff" attached, minus the binary part.

> BTW, do you use Mercurial? If yes, it is quite easy to export a set of
> patches and their comments with "hg export" command.

I had never used it, and I'm a bit too lazy to try to read a FAQ/manual to 
answer some questions:
- Is it possible to generate patches with binary data (for instance 
base64-encoded)? -a options seems dangerous even it qualifies for a yes. If 
no, then is what I've done (attach binary data to mail) the only solution?
- I did an hg add. It didn't complain. Is it only local? Where would the data 
end after a hg commit?

> So many remarks for a single icon! ;-)

Wars and other slaughters were committed in the name of some icons. We are not 
yet there hopefully. (this is intended as a play on words in the hope nobody 
will see matter in it)

Best regards,
--
Christophe GISQUET

diff -r bffa766612ce config/Makefile.inc
--- a/config/Makefile.inc       Sun Sep 24 12:09:31 2006 +0200
+++ b/config/Makefile.inc       Mon Sep 25 21:42:53 2006 +0200
@@ -102,6 +102,9 @@ ifeq ($(PLATFORM),win32)
 ifeq ($(PLATFORM),win32)
 CLNT_OCAMLCFLAGS += -ccopt -mwindows
 CLNT_OCAMLOPTFLAGS += -ccopt -mwindows
+
+gtk2-clnt/demexp-info.o: win32/demexp-info.rc misc/demexp-demo.ico
+       windres -i $< -o $@
 endif
 
 WEB_OCAMLCFLAGS:=$(WEB_OCAMLINC) -g -w Ale
@@ -381,7 +384,11 @@ client: gtk2-clnt/demexp-gtk2-client \
        gtk2-clnt/demexp-gtk2-client.bc
 
 ### native code
+ifeq ($(PLATFORM),win32)
+gtk2-clnt/demexp-gtk2-client: $(GTK2_CLNT_OBJ) gtk2-clnt/demexp-info.o
+else
 gtk2-clnt/demexp-gtk2-client: $(GTK2_CLNT_OBJ)
+endif
        $(OCAMLOPT) $(CLNT_OCAMLOPTFLAGS) -o $@ $(CLNT_CMXALIBS) $^
 
 ## bytecode
diff -r bffa766612ce win32/demexp-info.rc
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/win32/demexp-info.rc      Mon Sep 25 21:43:16 2006 +0200
@@ -0,0 +1,34 @@
+// resource for DemExp win32 client
+
+#include <winver.h>
+
+1 VERSIONINFO
+FILEVERSION    0,7,0,0
+PRODUCTVERSION 0,7,0,0
+FILEFLAGSMASK  0x3fL
+FILEOS VOS__WINDOWS32
+FILETYPE VFT_APP
+{
+    BLOCK "StringFileInfo"
+    {
+        BLOCK "000004b0"
+        {
+            VALUE "Comments","U2: Unsecure, Unstable"
+            VALUE "CompanyName", "DemExp association"
+            VALUE "FileDescription", "The Democratic Experiment client"
+            VALUE "FileVersion", "0.7.0"
+            VALUE "InternalName", "demexp"
+            VALUE "LegalCopyright", "Copyright (C) 2003-2006  David MENTRE et 
al."
+            VALUE "LegalTrademarks", "GPL 2"
+            VALUE "OriginalFilename", "demexp.exp"
+            VALUE "ProductName", "demexp"
+            VALUE "SpecialBuild", "Build date: " __DATE__ ", " __TIME__ " with 
compiler version " __VERSION__
+        }
+    }
+    BLOCK "VarFileInfo"
+    {
+        VALUE "Translation", 0x0, 1200
+    }
+}
+
+IDI_ICON1 ICON DISCARDABLE "misc/demexp-demo.ico"