[Demexp-dev] Before merging ketty's branch

[David MENTRE]

Hello Ketty,

I've started to look at how I could merge your branch to integrate your
modifications to demexpweb. Before doing the merge, I have some remarks
(by order of decreasing importance):

 1. why do you create a web/po/ directory instead of using po/
    directory? I don't like spreading po files all over the
    sources. Moreover, you have created web/po/Makefile. Once again, I
    prefer having a single Makefile at the top of the source tree;

 2. You have kept the call to Obj.magic;

 3. Be careful when recompiling the sources, gettext has a tendency to
    add its headers, even if they are already there. That makes the .po
    files messy. You should do a 'hg revert po/file' before doing a
    commit if the file was not modified (or edit it manually
    otherwise). 

    For example in changeset 434:

--- a/web/po/sv.po      Sun Oct 08 22:16:14 2006 +0200
+++ b/web/po/sv.po      Tue Oct 10 05:20:23 2006 +0200
@@ -1,3 +1,10 @@
+# #-#-#-#-#  sv.po (PACKAGE VERSION)  #-#-#-#-#
+# #-#-#-#-#  demexp-web.pot (PACKAGE VERSION)  #-#-#-#-#
+# SOME DESCRIPTIVE TITLE.
+# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
+# This file is distributed under the same license as the PACKAGE package.
+# FIRST AUTHOR <address@hidden>, YEAR.
+#
 # #-#-#-#-#  demexp-web.pot (PACKAGE VERSION)  #-#-#-#-#
 # SOME DESCRIPTIVE TITLE.
 # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
@@ -7,6 +14,7 @@
 #, fuzzy
 msgid ""
 msgstr ""
+"#-#-#-#-#  sv.po (PACKAGE VERSION)  #-#-#-#-#\n"
 "#-#-#-#-#  sv.po (PACKAGE VERSION)  #-#-#-#-#\n"

 4. There isn't much litterate comments; ;-)


Before merging your changes, I would much prefer that you change 1/ and
2/. For 4/, I could add them latter even if comments are of better
quality when written at the same time as the code (and by the coder ;-).


Best wishes,
d.
-- 
GPG/PGP key: A3AD7A2A David MENTRE <address@hidden>
 5996 CC46 4612 9CA4 3562  D7AC 6C67 9E96 A3AD 7A2A