Re: [dev-serveez] Patch to make Serveez compile with Guile 1.7 (CVS HEAD)

[stefan]

On 2 Feb 2003, Andreas Rottmann wrote:

> Hi!

Hello!

> I patched serveez to make it compile against Guile 1.7 (CVS HEAD). I
> tested moifications with Guile 1.4.1, 1.6.0 and 1.7 (CVS HEAD),
> succeeding to compile it in all cases. Patch is attached.

Thanks for the patch.  I already applied parts of it on my local copy and
would like to clarify some things...

1. Is it a good idea to SCM_SETVELTS(x,v) whereas 'v' is a local (stack)
   variable?  I think the previous version was correct.  Does it compile
   with Guile 1.7.0 without that part?

2. The change
   -GUILE_CONCAT2 (xsock->,func) = GUILE_CONCAT2 (guile_func_,func);
   +xsock->func = GUILE_CONCAT2 (guile_func_,func);
   is somehow irritating.  Does your compiler concatinate it correctly?

3. The rest of the patch is applied here.

Cheers,
        address@hidden