[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [dev-serveez] OS X compatibility patches
From: |
Thien-Thi Nguyen |
Subject: |
Re: [dev-serveez] OS X compatibility patches |
Date: |
Fri, 07 Feb 2014 09:34:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
() Julian Graham <address@hidden>
() Wed, 5 Feb 2014 22:07:56 -0500
[patches to get] Serveez (and libserveez) to
build on Mac OS X 10.8
- What's the right branch to apply them to?
This would be ‘p’ (there is a hint in HACKING to this effect).
- What are your conventions for commit messages? ttn, it looks like
you've been categorizing your commits as `maint', `lib', etc. Where
do compatibility fixes fit in?
I think of these not so much as categories (exclusive), but as tags
(group/set relationship). For Guile (libguile) compatibility, i have
used ‘slog’ in the past. Another common tag is ‘int’ (for "internal"),
which most compatibility changes fall under, usually. I suppose ‘slog’
implies ‘int’ so the latter is redundant. In this case, it sounds like
you could use something like:
[lib slog] Conditionalize foo for OSX.
or:
[lib slog osx] Conditionalize foo.
The system is not strictly defined or enforced; please hack freely.
Don't be afraid of the "; nfc." VCS entries, either.
- How would you like to receive them?
I think as a first step there is no harm simply posting them for review.
--
Thien-Thi Nguyen
GPG key: 4C807502
(if you're human and you know it)
read my lisp: (responsep (questions 'technical)
(not (via 'mailing-list)))
=> nil
pgpTmAB7Hj4BF.pgp
Description: PGP signature