Re: [PATCH] Menu code somewhat changed

[Willem Rein Oudshoorn]

Richard Frith-Macdonald <richard@brainstorm.co.uk> writes:

> On Sunday, February 23, 2003, at 08:02  pm, Willem Rein Oudshoorn wrote:
> 
> > The following patch changes slightly the mechanism
> > of the NSMenu (View) code.
> >
> > Changed behaviour
> > -----------------
> >
> > * Remove highlighting explicitly after executing action.
> >   (I guess the restore highlighting code was put there for
> >    a reason.  But I could not think of any.)
> >
> > * Remove the temporary menu before executing the
> >   action.
> 
> I this this out and found a few problems/bugs introduced
> by the patch....
> 
> When you select a menu item which brings up a submenu,
> the menu item should remain highlighted until the submenu
> is either closed or torn off, so you can see at a glance which
> menu item you should click to close the submenu.

This was done deliberately.  But now I understand the reason
for resetting the highlighting.  

Personally I found it a little bit annoying that the item
stayed highlighted and because the highlighting code was
not completely correct anyway I removed it.

> After your patch, the highlighting was missing ... and worse,
> clicking on the menu item again failed to close the submenu!

I just checked on OpenStep and the behaviour is indeed as you
describe.  

> Other than that, the patch looks good, and if you can fix the
> highlighting errors so that submenus operate correctly
> again, I'll commit it.

Ok, I will fix the highlighting.  Thanks for the explanation.


Wim Oudshoorn.