Re: Implementation of CommonCrypto?

[Niels Grewe]

Hi Amr,

> Am 11.06.2016 um 07:46 schrieb Amr Aboelela <amraboelela@gmail.com>:
> 
> Hi Nik
> Yes I should have used NSUTF8StringEncoding 
> I just found the root of the problem though:
> 
> CommonCrypto_for_GNUstep/Source/AESedp$ vim AESAssembly.h 
> 
> Change:
> 
> // Select which implementation to use.
> #if 1
>         #define UseAESedp_IntelAssembly
> #else
>         #define UseAESedp_GeneralC
> #endif
> 
> To:
> 
> // Select which implementation to use.
> #if 0
>         #define UseAESedp_IntelAssembly
> #else
>         #define UseAESedp_GeneralC
> #endif

I guess that might work, but it’s just a workaround for the problem. The root 
cause would probably lie within the architecture specific assembly code. You’ve 
just switched to the slow C implementation of the AES algorithm to make things 
work. That being said, the CommonCrypto port is seriously out of date, and 
Apple has essentially prevented us from doing a new one (short of a complete 
rewrite) because the newer CommonCrypto source dumps have a dependency on 
CoreCrypto, which is only available under a seriously restrictive evaluation 
license. So unless you are porting something with a lot of CommonCrypto calls, 
you might just be better off #ifdefing stuff to use openssl, gnutls or any 
other well maintained crypto library instead.

Cheers,

Niels