Re: [dmidecode] [PATCH v2 0/2] dmidecode: Add --handle option

[Jerry Hoemann]

On Mon, Jul 02, 2018 at 07:02:21PM +0200, Jean Delvare wrote:
> On Fri, 29 Jun 2018 15:32:59 -0600, Jerry Hoemann wrote:
> > Changes in v2
> > Addressed the following review comments
> > 01. Removed extra Parens in dmi_table_decode
> > 02. Removed defensive pointer validation in parse_opt_handle
> > 03. parse_opt_handle handle degenerate "" handle number
> > 04. Fixed typo in printf (nubmer)
> > 05. Missing ":" in optstring for 'H'
> > 06. Order presence of H to be in stH order through out.
> > 07. Add check for --handle and -s to be mutually exclusive.
> 
> I probably expressed myself incorrectly. I mentioned --handle and -s
> specifically because in theory they could be combined, but in practice
> this is not implemented yet. However -s is not the only option to be
> mutually exclusive with --handle. It is also mutually exclusive with
> --dump-bin, by nature, and with --type, by redundancy.
> 
> So my implied suggestion was to add "opt.handle != ~0U" to the current
> check, rather than creating a new check.
> 
> No need to resend, I can adjust before committing, if that's OK with
> you.

I'm okay with that.

Thanks

> 
> > 08. Remove extra space before "handle" in struct opt.
> > 09. "entry" no "entries" in handle docs.
> > (...)
> 
> -- 
> Jean Delvare
> SUSE L3 Support

-- 

-----------------------------------------------------------------------------
Jerry Hoemann                  Software Engineer   Hewlett Packard Enterprise
-----------------------------------------------------------------------------