dmidecode-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[dmidecode] [PATCH] dmioem: Nicer display of PCI device (HPE type 238)


From: Jean Delvare
Subject: [dmidecode] [PATCH] dmioem: Nicer display of PCI device (HPE type 238)
Date: Wed, 1 Jun 2022 10:06:15 +0200

Use the standard PCI device format (bus:dev.fn) to designate the
parent PCI device of the USB port, so it is much easier to lookup
in the output of lspci for example.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Jerry Hoemann <jerry.hoemann@hpe.com>
---
Jerry, what do you think? This would make the PCI device presentation
consistent with what we do for type 203.

 dmioem.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- dmidecode.orig/dmioem.c     2022-06-01 09:52:29.238550207 +0200
+++ dmidecode/dmioem.c  2022-06-01 09:57:30.181528594 +0200
@@ -666,9 +666,8 @@ static int dmi_decode_hp(const struct dm
                        if (h->length < 0x0F) break;
                        if (!(opt.flags & FLAG_QUIET))
                                pr_attr("Associated Handle", "0x%04X", 
WORD(data + 0x4));
-                       pr_attr("PCI Bus of Parent USB", "0x%04X", data[0x6]);
-                       pr_attr("PCI Device of Parent USB", "0x%04X", data[0x7] 
>> 3);
-                       pr_attr("PCI Function of Parent USB", "0x%04X", 
data[0x7] & 0x7);
+                       pr_attr("PCI Device", "%02x:%02x.%x", data[0x6],
+                               data[0x7] >> 3, data[0x7] & 0x7);
                        dmi_hp_238_loc("Location", data[0x8]);
                        dmi_hp_238_flags("Management Port", WORD(data + 0x9));
                        pr_attr("Port Instance", "%d", data[0xB]);


-- 
Jean Delvare
SUSE L3 Support



reply via email to

[Prev in Thread] Current Thread [Next in Thread]