dmidecode-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] dmidecode: Correct Redish HI device type OEM value


From: Jean Delvare
Subject: Re: [PATCH v2 1/2] dmidecode: Correct Redish HI device type OEM value
Date: Tue, 13 Jun 2023 18:19:17 +0200

On Fri,  9 Jun 2023 18:39:18 +0800, John Chung wrote:
> Device type OEM value should be 0x80h ~ 0xFFh in DSP0270.
> 
> Fixes: 78539b0 ("dmidecode: Parse Modern Management Controller blocks")
> Signed-off-by: John Chung <john.chung@arm.com>
> ---
>  dmidecode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dmidecode.c b/dmidecode.c
> index a288acd..6926a93 100644
> --- a/dmidecode.c
> +++ b/dmidecode.c
> @@ -4131,7 +4131,7 @@ static void dmi_parse_controller_structure(const struct 
> dmi_header *h)
>                       pr_attr("SubDeviceID", "0x%04x",
>                               WORD(&pcidata[0x6]));
>               }
> -             else if (type == 0x4 && len >= 5)
> +             else if (type >= 0x80 && len >= 5)
>               {
>                       /* OEM Device Type - Need at least 4 bytes */
>                       u8 *oemdata = &data[0x7];

Applied, thanks.

-- 
Jean Delvare
SUSE L3 Support



reply via email to

[Prev in Thread] Current Thread [Next in Thread]