[Dolibarr-bugtrack] [bug #18592] stock movement issues

[Franky Van Liedekerke]

Follow-up Comment #2, bug #18592 (project dolibarr):

Well, I fixed the first problem as well:
-

In htdocs/commande/commande.class.php, function cancel(), before the lines
        $sql = 'UPDATE '.MAIN_DB_PREFIX.'commande SET fk_statut = -1';
        $sql .= " WHERE rowid = $this->id AND fk_statut = 1 ;";

add the following lines to correctly adjust the stock:

        foreach($this->lignes as $ligne) {
           $product = new Product($this->db);
           $product->id = $ligne->fk_product;
           $product->ajust_stock_commande($ligne->qty, 1);
        }

in the function delete_ligne they use a much more elaborated way of doing
this (a new $obj is created to get the quantity), but this simple way seems
to work just fine :)

This fix is also needed in the function delete() in the same file, but there
I would put these lines after the db->commit, like this:
        $this->db->commit();
        foreach($this->lignes as $ligne) {
           $product = new Product($this->db);
           $product->id = $ligne->fk_product;
           $product->ajust_stock_commande($ligne->qty, 1);
        }
        return 1;

Franky

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?18592>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/