Dolibarr ERP & CRM » Bugs » bug #1237 Send by Email creates broken http URLLatest modifications
Answer now
Snapshot| Details |
| Last Modified On: | 2014-02-06 17:11 | | Submitted by: | Fred Laxton (flaxton) |
| Submitted on: | 2014-02-06 17:02 | |
| Summary: | Send by Email creates broken http URL |
| Description: | I sent two invoices by email, and both of the http URL links were broken.
I click "Send by Email" on an invoice, and it puts this in the email:
"You will find here the invoice FA1401-0025
You can click on the secure link below to make your payment (PayPal) if it is not already done.\n\nhttp://infotechdesign.us/public/paypal/newpayment.php?source=invoice&ref=FA1401-0025\n\nSincerely"
This part, before the URL:
\n\n
and this part, after the URL:
\n\nSincerely
munge it so it does not work. If they get there, it doesn't understand the invoice number, and instead shows $1.00 in place of the correct amount.
Yes, I know that \n\n means "newline" in some contexts. But it is actually putting "nn" into the email text, not a newline, making it part of the URL.
I believe the problem is in:
langs/en_US/other.lang
I'm thinking the \n (newline) is not recognized if does not have spaces before and after, but that's just a theory. |
| Step to reproduce bug: | Send an invoice by email. |
| Detected in version: | 3.5.0 | | Category: | Module: Customer Invoices |
| Severity: | 5 - Major | | OS Type/Version: | CentOS 6.3 |
| PHP version: | 5.4.22 | | Database type and version: | MySQL 5.5.33 |
| Status |
| Status: | Open | | Assigned to: | Laurent Destailleur (eldy) |
| Resolution: | Fixed | |
Comments- Laurent Destailleur 2014-02-08 02:39
- The bug has been corrected inside GIT sources
(http://www.github.com/Dolibarr/dolibarr).
So fix should be available with next stable release. - Fred Laxton 2014-02-06 17:11
- This is found in langs/en_US/paypal.lang. This can be fixed by changing the \n (newline) to <br /> (html line break).
Change:
PredefinedMailContentLink=You can click on the secure link below to make your payment (PayPal) if it is not already done.\n\n%s\n\n
To:
PredefinedMailContentLink=You can click on the secure link below to make your payment (PayPal) if it is not already done.<br /><br /> %s <br /><br />
and that fixes it, keeping the URL completely separate from the surrounding text.
|
|
(http://www.github.com/Dolibarr/dolibarr).
So fix should be available with next stable release.
None→ Laurent Destailleur (eldy)None→ Fixed