[Libjit-developers] Re: libjit changes for archs with native ints (pointer sizes) greater than 32 bit

[Aleksey Demakov]

Hi Klaus,

> On making the interpreter running the pnet hello sample on x86_64 i
> stepped over some code wrapped in #if JIT_NATIVE_INT32 or #if
> JIT_NATIVE_INT64 in jit-insn.c that confuses me.
>
> So i have one question:
>
> The type jit_int is always 4 bytes in size. So why is there this
> conditional compilation?

These #ifs are for the target platform's native int not for
jit_int.

> An other issue is that pointers (native int) are longs on 64 bit archs.
> Is it correct to set the is_nint_constant in
> jit_value_create_long_constant?
>

What problem does it solve? I see no need for this change.

>
> Doing some of the changes made pnet's hello sample run with libjit
> interpreter on x86_64.
>

That's strange that it made a difference in your setup. These
changes do not seem to fix any real problem for me.

Regards,
Aleksey