Re: [Pnet-developers] [patch #3119] jit_flush_exec () for x86

[Rhys Weatherley]

On Tuesday 08 June 2004 07:31 am, Miroslaw Dobrzanski-Neumann wrote:

> Summary:  jit_flush_exec () for x86
>
> Original Submission:  cache flush for x86 processors that supports it.

Actually, none of the x86 processors "need" cache flushing according to the 
documentation.  It helps performance a little, but it isn't required.

The use of global variables and state initialization does concern me a little, 
as closures may be created without first calling "jit_init". Was there a 
reason why you didn't query the cpuid on the fly?  (We do need a 
general-purpose "get x86 cpuid" function elsewhere, so I will add that).

> the macro ROUND_END_PTR is fixed also

I'll apply this part of the patch immediately, as it is a bug.

I'll leave the rest of the patch open for now so that we can discuss it 
further.

Cheers,

Rhys.