[Pnet-developers] [bugs #10917] libjit convert to int bug patch

[Evin Robertson]

This mail is an automated notification from the bugs tracker
 of the project: DotGNU Portable.NET.

/**************************************************************************/
[bugs #10917] Latest Modifications:

Changes by: 
                Evin Robertson <address@hidden>
'Date: 
                Tue 11/30/04 at 04:07 (GMT)

------------------ Additional Follow-up Comments ----------------------------
I noticed this bug again.  I was attempting to do an unsigned comparison of two 
integers.  So I converted both to jit_type_uint.  But the conversion did not 
take place.  Another patch is attached which corrects this.







/**************************************************************************/
[bugs #10917] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=10917>
Project: DotGNU Portable.NET
Submitted by: Evin Robertson
On: Fri 11/05/04 at 05:35

Category:  None
Severity:  5 - Average
Item Group:  None
Resolution:  None
Privacy:  Public
Assigned to:  None
Status:  Open


Summary:  libjit convert to int bug patch

Original Submission:  Similar in symptom to the previous bug.  If a write is 
made from one global variable to another, the type of the source might be used 
instead of the type of the destination.

The problem is that jit_insn_store_relative determines its mode of operation 
from the source value.  So the first problem is that dpas does not run 
jit_insn_convert on the source value to give the store enough information.

The second problem is that jit_insn_convert does not work properly when going 
from an unsigned byte to an integer.  The value returned is the original value 
without the correct type.

A patch is attached which corrects both problems.  Probably other CVT_NONE 
values should be replaced as well.

Because every call to jit_insn_store_relative will likely be preceded by a 
jit_insn_convert, perhaps it should be modified to take an extra parameter 
giving the destination type.

program loadb;

Var
   a : Byte;
   b : Integer;

Procedure run;
Var x :  Integer;
begin
   b := a;
   x := a;
   WriteLn(a);
   WriteLn(b);
   WriteLn(x);
end;

begin
   a := 250;
   b := -1;
   run;
end.


Follow-up Comments
------------------


-------------------------------------------------------
Date: Tue 11/30/04 at 04:07         By: Evin Robertson <evin>
I noticed this bug again.  I was attempting to do an unsigned comparison of two 
integers.  So I converted both to jit_type_uint.  But the conversion did not 
take place.  Another patch is attached which corrects this.





CC List
-------

CC Address                          | Comment
------------------------------------+-----------------------------
rweather --AT-- zip --DOT-- com --DOT-- au | 



File Attachments
-------------------

-------------------------------------------------------
Date: Tue 11/30/04 at 04:07  Name: jit2.patch  Size: 512B   By: evin
Patch for uint conversion
http://savannah.gnu.org/bugs/download.php?item_id=10917&amp;item_file_id=1927

-------------------------------------------------------
Date: Fri 11/05/04 at 05:35  Name: jit.patch  Size: 676B   By: evin

http://savannah.gnu.org/bugs/download.php?item_id=10917&amp;item_file_id=1841






For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=10917>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/