[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Duplicity-talk] unused assert
From: |
Kenneth Loafman |
Subject: |
Re: [Duplicity-talk] unused assert |
Date: |
Thu, 21 Aug 2008 06:15:51 -0500 |
User-agent: |
Thunderbird 2.0.0.16 (X11/20080724) |
Jason Dusek wrote:
> The assert claims to check a condition that is guaranteed by
> the preceeding code.
>
> --
> _jsn
>
> --- src/collections.py.old 2008-07-22 08:20:04.000000000 -0700
> +++ src/collections.py 2008-08-20 20:22:07.000000000 -0700
> @@ -479,8 +479,7 @@
> (backup_chains, self.orphaned_backup_sets,
> self.incomplete_backup_sets) = \
> self.get_backup_chains(backend_filename_list)
> - backup_chains = self.get_sorted_chains(backup_chains)
> - self.all_backup_chains = backup_chains
> + self.all_backup_chains = self.get_sorted_chains(backup_chains)
>
> assert len(backup_chains) ==
> len(self.all_backup_chains), "get_sorted_chains() did something more
> than re-ordering"
At some point get_sorted_chains() must have screwed up. Perhaps it
would be wise to assume it might happen again.
...Ken
signature.asc
Description: OpenPGP digital signature