[debbugs-tracker] bug#36537: closed ([PATCH] discovery: Handle edge case in scheme-files when looking at symlinks.)

[GNU bug Tracking System]

Your message dated Mon, 08 Jul 2019 17:56:26 +0100
with message-id <address@hidden>
and subject line Re: [bug#36537] [PATCH] discovery: Handle edge case in 
scheme-files when looking at symlinks.
has caused the debbugs.gnu.org bug report #36537,
regarding [PATCH] discovery: Handle edge case in scheme-files when looking at 
symlinks.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36537: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36537
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks.
>
>
>
>
> Date: 
>
> Sun,  7 Jul 2019 12:21:02 +0100
>
>
>
>
> Previously, this code would cause crashes in Guix (running guix package -s for
> example) which could be experienced when Emacs creates temporary files in the
> gnu/packages/patches directory when a patch file has been edited, but not
> saved.
>
> * guix/discovery.scm (scheme-files): Add else clause to cond used when
> handling symlinks.
> ---
>  guix/discovery.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/guix/discovery.scm b/guix/discovery.scm
> index 5bb494941b..86f20ec344 100644
> --- a/guix/discovery.scm
> +++ b/guix/discovery.scm
> @@ -78,7 +78,9 @@ DIRECTORY is not accessible."
>                                   ((= stat:type 'directory)
>                                    (append (scheme-files absolute)
>                                            result))
> -                                 (_ result)))))
> +                                 (_ result)))
> +                              (else
> +                               result)))
>                         (else
>                          result))))))
>                '()
> -- 
> 2.22.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks. Date: Mon, 08 Jul 2019 17:56:26 +0100 User-agent: mu4e 1.2.0; emacs 26.2

Ludovic Courtès <address@hidden> writes:

> Hi Chris,
>
> Christopher Baines <address@hidden> skribis:
>
>> Previously, this code would cause crashes in Guix (running guix package -s 
>> for
>> example) which could be experienced when Emacs creates temporary files in the
>> gnu/packages/patches directory when a patch file has been edited, but not
>> saved.
>>
>> * guix/discovery.scm (scheme-files): Add else clause to cond used when
>> handling symlinks.
>
> Good catch, LGTM!

Great, I've pushed this now :)

signature.asc
Description: PGP signature

--- End Message ---