[debbugs-tracker] bug#36602: closed ([PATCH] Add node-build-system.)

[GNU bug Tracking System]

Your message dated Sun, 14 Jul 2019 12:34:53 +0200
with message-id <address@hidden>
and subject line Re: [bug#36602] [PATCH] Add node-build-system.
has caused the debbugs.gnu.org bug report #36602,
regarding [PATCH] Add node-build-system.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36602: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36602
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Add node-build-system. Date: Thu, 11 Jul 2019 18:46:53 +0200

Hi Guix!

This patch adds a node-build-system. I wasn't sure if it was ready yet,
but I think, since I didn't change it in the last months, that it might
actually be :)

The patch was initially made by Jelle Licht, and I improved a bit on
it. Note that packages built with this build system will embed symlinks
to their dependencies, but not devDependencies (build-only
dependencies) according to the information in the metadata. Each
package is installed in lib/node_modules/package-name and symlinks are
added to lib/node_modules/package-name/node_modules. This allows us to
use only inputs instead of propagated inputs. Executables are installed
in bin according to metadata, and they should work even if called
directly from their store path.

0001-build-Add-node-build-system.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#36602] [PATCH] Add node-build-system.
>
>
>
>
> Date: 
>
> Sun, 14 Jul 2019 12:34:53 +0200
>
>
>
>
> Le Sat, 13 Jul 2019 23:30:12 +0200,
> Jelle Licht <address@hidden> a écrit :
>
> > Julien Lepiller <address@hidden> writes:
> > 
> > > [...]
> > > +(define* (install #:key outputs inputs #:allow-other-keys)
> > > +  "Install the node module to the output store item. MODULENAME
> > > defines +under which name the module will be installed, GLOBAL?
> > > determines whether this +is an npm global install."  
> > 
> > `global?' is no longer , so it could probably be removed from the
> > docstring as well. LGTM otherwise :-).
>
> I've reworked that docstring and pushed as
> 09a1f92f61d1ab11d2cf9f7a0983f4fc9f436f57, thank you!
>
>
> --- End Message ---