[debbugs-tracker] bug#36371: closed ('--with-commit' does not support tags)

[GNU bug Tracking System]

Your message dated Fri, 26 Jul 2019 12:38:25 +0200
with message-id <address@hidden>
and subject line Re: bug#36371: guix build --with-git-reference=…
has caused the debbugs.gnu.org bug report #36371,
regarding '--with-commit' does not support tags
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36371: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36371
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: guix build --with-git-reference=… Date: Tue, 25 Jun 2019 11:24:33 +0200

Guix,

bricewge on #guix informed me that there's no way to pass a git tag as source transformation option. Indeed:

 ‘--with-commit=PACKAGE=COMMIT’

This is similar to ‘--with-branch’, except that it builds from COMMIT rather than the tip of a branch. COMMIT must be a valid Git

    commit SHA1 identifier.

is quite different from (guix git-download)'s pleasantly liberal notion of commit:

 (git reference
   (url "git://foo.org/fizbo")
   (commit "fizbo-4.5"))      ; tag yay

bricewge suggested that a single ‘--with-git-ref[erence]=’ could replace both ‘--with-branch’ and a new ‘--with-tag’, and I agree. (Although I prefer the full spelling, of course :-)

Two questions:
- Is this really not supported yet, or am I missing the obvious?

- Why is the (extremely) git-specific ‘--with-commit=’ option not called ‘--with-git-commit=’? Was it intended to be more generic than it is now? Should the new option be ‘--with-reference=’ as well? That's pushing it a little far. And three questions in one; I'm cheating.

Kind regards,

T G-R

signature.asc
Description: PGP signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#36371: guix build --with-git-reference=…
>
>
>
>
> Date: 
>
> Fri, 26 Jul 2019 12:38:25 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
>
>
>
>
> Hello!
>
> Ludovic Courtès <address@hidden> skribis:
>
> > $ guix build guile-gcrypt --with-commit=guile-gcrypt=v1.0.0
> > updating checkout of 'https://notabug.org/cwebber/guile-gcrypt.git'...
> > guix build: error: cannot fetch commit v1.0.0 from 
> > https://notabug.org/cwebber/guile-gcrypt.git: unable to parse OID - contains 
> > invalid characters
> >
> > Internally, that uses the ‘git-checkout’ record type defined in (guix
> > git).
> >
> > What I would propose is to change ‘git-checkout-compiler’ so that it can
> > determine with a simple heuristic like that of (@@ (guix swh) commit-id?)
> > whether the string denotes a commit ID or a tag.
>
> Done in 177fecb57c0c9e15249bf6a49244c9dc6eb8439c.
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---