emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#36765: closed (27.0.50; gnus-group-split-setup sho


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#36765: closed (27.0.50; gnus-group-split-setup should delay until Gnus has finished starting up)
Date: Sat, 27 Jul 2019 16:20:03 +0000

Your message dated Sat, 27 Jul 2019 09:19:40 -0700
with message-id <address@hidden>
and subject line Re: bug#36765: 27.0.50; gnus-group-split-setup should delay 
until Gnus has finished starting up
has caused the debbugs.gnu.org bug report #36765,
regarding 27.0.50; gnus-group-split-setup should delay until Gnus has finished 
starting up
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36765: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36765
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 27.0.50; gnus-group-split-setup should delay until Gnus has finished starting up Date: Mon, 22 Jul 2019 11:22:53 -0700
The Gnus manual instructs users to put a call to
`gnus-group-split-setup' in their gnus.el file if they want to skip over
some tedious manual configuration.

The problem with this is that the function has:

  (gnus-group-split-update)
  (when auto-update
    (add-hook 'nnmail-pre-get-new-mail-hook 'gnus-group-split-update))

Meaning that `gnus-group-split-update' is called immediately when this
function is run, which happens before Gnus is done starting up.
split-update calls `gnus-group-split-fancy' which ends up accessing
group parameters on all Gnus groups. Parameter access only works when
gnus-newsrc-hashtb is already initialized. When the hashtb was an
obarray, this process was a silent no-op. Now that they're hashtables,
it signals a type error.

I think a simple solution would be to change the above to:

(add-hook (if auto-update
              'nnmail-pre-get-new-mail-hook
            'gnus-started-hook)
          'gnus-group-split-update)

Ie, if auto-update isn't passed, only run the update once, at start time.



--- End Message ---
--- Begin Message --- Subject: Re: bug#36765: 27.0.50; gnus-group-split-setup should delay until Gnus has finished starting up Date: Sat, 27 Jul 2019 09:19:40 -0700 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Lars Ingebrigtsen <address@hidden> writes:

> Eric Abrahamsen <address@hidden> writes:
>
>> Okay, I've heard back from the user. I think the proper solution is:
>>
>> (add-hook (if auto-update
>>            'gnus-get-top-new-news-hook
>>          'gnus-read-newsrc-el-hook)
>>        #'gnus-group-split-update)
>>
>> The reasoning being:
>
> [...]
>
>> WDYT?
>
> Sounds good.

Thanks -- pushed.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]