[debbugs-tracker] bug#37708: closed ([PATCH] gnu: add uchardet)

[GNU bug Tracking System]

Your message dated Sat, 12 Oct 2019 15:16:53 +0200
with message-id <address@hidden>
and subject line Re: [bug#37708] [PATCH] gnu: add uchardet
has caused the debbugs.gnu.org bug report #37708,
regarding [PATCH] gnu: add uchardet
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
37708: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37708
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: add uchardet
>
>
>
>
> Date: 
>
> Fri, 11 Oct 2019 23:51:03 +0330
>
>
>
>
> User-agent: 
>
> Trojita/0.7-git; Qt/5.11.3; xcb; Linux; 
>
>
>
>
> > From 5bbab834e617c0bfb14d384e05af390d05728b6e Mon Sep 17 00:00:00 2001
> From: Reza Alizadeh Majd <address@hidden>
> Date: Fri, 11 Oct 2019 23:23:21 +0330
> Subject: [PATCH] gnu: add uchardet
>
> * gnu/packages/freedesktop.scm (uchardet) New variable.
> ---
> gnu/packages/freedesktop.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index 401f54bb14..51848be170 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -14,6 +14,7 @@
> ;;; Copyright © 2018 Tobias Geerinckx-Rice <address@hidden>
> ;;; Copyright © 2018 Pierre Neidhardt <address@hidden>
> ;;; Copyright © 2018 Stefan Stefanović <address@hidden>
> +;;; Copyright © 2019 Reza Alizadeh Majd <address@hidden>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -1409,3 +1410,24 @@ This package also contains two related utilities:
> their MIME type.
> @end itemize")
>     (license license:perl-license)))
> +
> +(define-public uchardet
> +  (package
> +    (name "uchardet")
> +    (version "0.0.6")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://www.freedesktop.org/software/"; 
> +                            name "/releases/" name "-" version ".tar.xz"))
> +        (sha256
> +          (base32 
> "0q9c02b6nmw41yfsiqsnphgc3f0yg3fj31wkccp47cmwvy634lc3"))))
> +    (build-system cmake-build-system)
> +    (arguments `(#:tests? #f))
> +    (home-page "https://www.freedesktop.org/wiki/Software/uchardet/";)
> +    (synopsis "encoding detector library")
> +    (description "uchardet is an encoding detector library, which takes a 
> +sequence of bytes in an unknown character encoding without any additional 
> +information, and attempts to determine the encoding of the text. Returned 
> +encoding names are iconv-compatible.")
> +    (license license:gpl2+)))
> --
> Regards
> Reza Alizadeh Majd
> PantherX Team
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#37708] [PATCH] gnu: add uchardet
>
>
>
>
> Date: 
>
> Sat, 12 Oct 2019 15:16:53 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hi Reza,
>
> Reza Alizadeh Majd <address@hidden> skribis:
>
> > From 5bbab834e617c0bfb14d384e05af390d05728b6e Mon Sep 17 00:00:00 2001
> > From: Reza Alizadeh Majd <address@hidden>
> > Date: Fri, 11 Oct 2019 23:23:21 +0330
> > Subject: [PATCH] gnu: add uchardet
> >
> > * gnu/packages/freedesktop.scm (uchardet) New variable.
>
> Applied with the modifications below, which address ‘guix lint’ warnings
> (remember to run it next time :-)), enable tests, and clarify the
> license.
>
> Thank you for the patch!
>
> Ludo’.
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index 17736aa537..4339f14f35 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -1423,16 +1423,18 @@ their MIME type.
>      (source
>        (origin
>          (method url-fetch)
> -        (uri (string-append "https://www.freedesktop.org/software/"; 
> +        (uri (string-append "https://www.freedesktop.org/software/";
>                              name "/releases/" name "-" version ".tar.xz"))
>          (sha256
>            (base32 "0q9c02b6nmw41yfsiqsnphgc3f0yg3fj31wkccp47cmwvy634lc3"))))
>      (build-system cmake-build-system)
> -    (arguments `(#:tests? #f))
>      (home-page "https://www.freedesktop.org/wiki/Software/uchardet/";)
> -    (synopsis "encoding detector library")
> -    (description "uchardet is an encoding detector library, which takes a 
> -sequence of bytes in an unknown character encoding without any additional 
> -information, and attempts to determine the encoding of the text. Returned 
> +    (synopsis "Encoding detector library")
> +    (description "uchardet is an encoding detector library, which takes a
> +sequence of bytes in an unknown character encoding without any additional
> +information, and attempts to determine the encoding of the text.  Returned
>  encoding names are iconv-compatible.")
> +
> +    ;; This combines code under MPL 1.1, LGPL 2.1+, and GPL 2.0+, so the
> +    ;; combination is GPL 2.0+.
>      (license license:gpl2+)))
>
> --- End Message ---