bug#37756: closed ([PATCH] Wrong initialization of fringe bitmap)

[GNU bug Tracking System]

Your message dated Sat, 26 Oct 2019 13:21:25 +0300
with message-id <address@hidden>
and subject line Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap
has caused the debbugs.gnu.org bug report #37756,
regarding [PATCH] Wrong initialization of fringe bitmap
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
37756: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37756
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Wrong initialization of fringe bitmap Date: Mon, 14 Oct 2019 23:39:19 -0300

In fringe.c:1606 you have:

  xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW);
  fb.bits = b = ((unsigned short *)
ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW));
  xfb = ptr_bounds_clip (xfb, sizeof *xfb);
  memset (b, 0, fb.height);

I might be wrong but it seems to me that the last line should be:

  memset (b, 0, fb.height * BYTES_PER_BITMAP_ROW);

instead.

I've attached a patch that does exactly that.

Best regards
--
Carlos

0001-Fix-zero-initialization-of-fringe-bitmap.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap
>
>
>
>
> Date: 
>
> Sat, 26 Oct 2019 13:21:25 +0300
>
>
>
>
> > From: Carlos Pita <address@hidden>
> > Date: Wed, 16 Oct 2019 17:01:11 -0300
> > Cc: address@hidden
> > 
> > I'm having some issues doing that because I'm using magit to amend /
> > reword previously committed changes, so the instructions there don't
> > quite match my situation. Will try harder later, for now I just
> > modified the message after some examples in your git log. Hope it's ok
> > now.
>
> Thanks, pushed.  Closing the bug.
>
> > From: memeplex <address@hidden>
>         ^^^^^^^^
> Is this really how you want your name to appear in the Git log?
>
>
> --- End Message ---