emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#44981: closed (28.0.50; Restore nnimap-split-download-body?)


From: GNU bug Tracking System
Subject: bug#44981: closed (28.0.50; Restore nnimap-split-download-body?)
Date: Thu, 03 Dec 2020 18:21:01 +0000

Your message dated Thu, 03 Dec 2020 10:20:01 -0800
with message-id <87k0ty92ge.fsf@ericabrahamsen.net>
and subject line Re: bug#44981: 28.0.50; Restore nnimap-split-download-body?
has caused the debbugs.gnu.org bug report #44981,
regarding 28.0.50; Restore nnimap-split-download-body?
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44981: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44981
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 28.0.50; Restore nnimap-split-download-body? Date: Mon, 30 Nov 2020 20:12:13 -0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
When splitting IMAP messages in Gnus' nnimap, there is a defvar called
`nnimap-split-download-body-default', which is consulted to decide
whether to download the whole message body during splitting, or only
consider its headers.

It appears that there used to be a defcustom called
`nnimap-split-download-body', which was advertised to the user, and this
defvar was used to hold... its default? It's odd.

In 2010, in commit 20a673b2d, a bunch of external Gnus code was merged
in, changing a lot of nnimap.el, and in the course of that the defcustom
was deleted. The defvar still remains, and is still effective. The
manual still refers to the customization option.

This looks unintentional, and I'd like to apply the attached diff,
restoring `nnimap-split-download-body' as a user option, and getting rid
of the default variable, which seems unnecessary. If this seems okay
I'll do up a proper commit, and make sure the documentation is all
accurate.

The same user who reported this also expressed a desire to be able to
download message bodies conditionally, based on the headers, only if
a split rule required it. I'm not at all sure about the feasibility of
that, but wanted to see if anyone else had an opinion.

Eric


Attachment: nnimap-split-body.diff
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? Date: Thu, 03 Dec 2020 10:20:01 -0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
Lars Ingebrigtsen <larsi@gnus.org> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Here's a proper commit.
>
> Looks good to me.

Thanks, done.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]