bug#45059: closed ([PATCH] gnu: freecad: Fix compilation flags)

[GNU bug Tracking System]

Your message dated Sun, 06 Dec 2020 22:29:51 +0100
with message-id <871rg21v3k.fsf@gnu.org>
and subject line Re: [bug#45059] [PATCH] gnu: freecad: Fix compilation flags
has caused the debbugs.gnu.org bug report #45059,
regarding [PATCH] gnu: freecad: Fix compilation flags
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
45059: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45059
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: freecad: Fix compilation flags
>
>
>
>
> Date: 
>
> Sat, 05 Dec 2020 23:51:30 +0000
>
>
>
>
> Hi everyone,
>
> I managed to solve the longstanding issue with freecad's compilation (#43448).
>
> I'll submit a new change with the package update to 0.18.5 next.
>
> Thanks
>
>
>
> >From d4d8a65679406b212c68d5198f239bdd71395541 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Sun, 6 Dec 2020 00:43:36 +0100
> Subject: [PATCH] gnu: freecad: Fix compilation flags
>
>     * gnu/packages/engineering.scm (freecad)[arguments]: Set correct
>     search paths in compilation flags. Fixes #43448
> ---
>  gnu/packages/engineering.scm | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 558541dd5a..5a8977c940 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -2496,8 +2496,28 @@ full programmatic control over your models.")
>         #:configure-flags
>         (list
>          "-DBUILD_QT5=ON"
> -        (string-append "-DCMAKE_INSTALL_LIBDIR="
> -                       (assoc-ref %outputs "out") "/lib"))
> +        (string-append "-DCMAKE_INSTALL_LIBDIR=" (assoc-ref %outputs "out") 
> "/lib")
> +
> +        (string-append "-DPYSIDE2UICBINARY="
> +                       (assoc-ref %build-inputs "python-pyside-2-tools")
> +                       "/bin/uic")
> +        (string-append "-DPYSIDE2RCCBINARY="
> +                       (assoc-ref %build-inputs "python-pyside-2-tools")
> +                       "/bin/rcc")
> +
> +        "-DPYSIDE_LIBRARY=PySide2::pyside2"
> +        (string-append
> +         "-DPYSIDE_INCLUDE_DIR="
> +         (assoc-ref %build-inputs "python-pyside-2") "/include;"
> +         (assoc-ref %build-inputs "python-pyside-2") "/include/PySide2;"
> +         (assoc-ref %build-inputs "python-pyside-2") "/include/PySide2/QtCore;"
> +         (assoc-ref %build-inputs "python-pyside-2") 
> "/include/PySide2/QtWidgets;"
> +         (assoc-ref %build-inputs "python-pyside-2") "/include/PySide2/QtGui;")
> +
> +        "-DSHIBOKEN_LIBRARY=Shiboken2::libshiboken"
> +        (string-append "-DSHIBOKEN_INCLUDE_DIR="
> +                       (assoc-ref %build-inputs "python-shiboken-2")
> +                       "/include/shiboken2"))
>         #:phases
>         (modify-phases %standard-phases
>           (add-before 'configure 'restore-pythonpath
> --
> 2.28.0
>
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#45059] [PATCH] gnu: freecad: Fix compilation flags Date: Sun, 06 Dec 2020 22:29:51 +0100

Ekaitz Zarraga <ekaitz@elenq.tech> skriver:

> Hi everyone,
>
> I managed to solve the longstanding issue with freecad's compilation (#43448).
>
> I'll submit a new change with the package update to 0.18.5 next.

Thanks a lot for these patches Ekaitz!

I pushed them both with 383f087cd74316d26c5c0f19b73bc620312c5477.

signature.asc
Description: PGP signature

--- End Message ---