bug#44922: closed ([PATCH 0/6] Prometheus node exporter service enhancements)

[GNU bug Tracking System]

Your message dated Mon, 07 Dec 2020 09:22:08 +0000
with message-id <87a6uqq8cf.fsf@cbaines.net>
and subject line Re: [bug#44922] [PATCH 0/6] Prometheus node exporter service 
enhancements
has caused the debbugs.gnu.org bug report #44922,
regarding [PATCH 0/6] Prometheus node exporter service enhancements
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44922: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44922
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH 0/6] Prometheus node exporter service enhancements Date: Sat, 28 Nov 2020 12:04:23 +0000 User-agent: mu4e 1.4.13; emacs 27.1

Some patches to enhance the Prometheus node exporter service.

Christopher Baines (6):
  services: monitoring: Neaten up the Prometheus node exporter.
  monitoring: Add user and group for the Prometheus node exporter.
  services: monitoring: Use a log file for Prometheus node exporter.
  doc: Remove redundant node exporter configuration from the example.
  monitoring: Enable the Prometheus node exporter textfile collector.
  monitoring: Support extra options for the Prometheus node exporter.

 doc/guix.texi               | 15 ++++---
 gnu/services/monitoring.scm | 81 ++++++++++++++++++++++++++++++-------
 2 files changed, 76 insertions(+), 20 deletions(-)

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#44922] [PATCH 0/6] Prometheus node exporter service enhancements Date: Mon, 07 Dec 2020 09:22:08 +0000 User-agent: mu4e 1.4.13; emacs 27.1

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>>   services: monitoring: Neaten up the Prometheus node exporter.
>>   monitoring: Add user and group for the Prometheus node exporter.
>>   services: monitoring: Use a log file for Prometheus node exporter.
>>   doc: Remove redundant node exporter configuration from the example.
>>   monitoring: Enable the Prometheus node exporter textfile collector.
>>   monitoring: Support extra options for the Prometheus node exporter.
>     ^
> Should be “services: prometheus-node-exporter: …”.
>
> Apart from that, on a quick look it LGTM.  Go for it!

Great, I've pushed as 92f7c11af26580a7e6543efa94531652f187923a.

Thanks,

Chris

signature.asc
Description: PGP signature

--- End Message ---