bug#45028: closed ([PATCH] offload: Print warning in context.)

[GNU bug Tracking System]

Your message dated Tue, 15 Dec 2020 15:04:53 +0100
with message-id <20201215150453.423185f2@tachikoma.lepiller.eu>
and subject line Re: [bug#45028] [PATCH] offload: Print warning in context.
has caused the debbugs.gnu.org bug report #45028,
regarding [PATCH] offload: Print warning in context.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
45028: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45028
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] offload: Print warning in context. Date: Thu, 3 Dec 2020 20:52:37 +0100

Hi Guix, attached is a patch to add context to the warning about the
system field. When offloading, we get this message if we haven't
updated our machines.scm:

guix offload: warning: The 'system' field is deprecated, please use
'systems' instead.

and it's not clear what system field this message is refering to
(especially for me, since I simply re-enabled offloading after a few
months by copying my old backup machines.scm).

Now the message is:

/etc/guix/machines.scm:9:6: warning: The 'system' field is deprecated,
please use 'systems' instead.

which directs the user to the right file, and line (so if you have many
offload machines, you know where to fix).

Since the message comes from the daemon, you need to run the daemon
from your guix checkout to test the patch.

0001-offload-Print-warning-in-context.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#45028] [PATCH] offload: Print warning in context.
>
>
>
>
> Date: 
>
> Tue, 15 Dec 2020 15:04:53 +0100
>
>
>
>
> Pushed as 954e4cf6a4cc67701dff8d089e8e02861e3b36c2, thank you!
>
>
> --- End Message ---