bug#46832: closed ([PATCH] import: hackage: Accept optional version paramter.)

[GNU bug Tracking System]

Your message dated Mon, 01 Mar 2021 17:02:13 +0100
with message-id <878s76rhfe.fsf_-_@gnu.org>
and subject line Re: bug#46833: [PATCH v2] import: hackage: Accept optional 
version parameter.
has caused the debbugs.gnu.org bug report #46833,
regarding [PATCH] import: hackage: Accept optional version paramter.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46833: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46833
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] import: hackage: Accept optional version paramter.
>
>
>
>
> Date: 
>
> Sun, 28 Feb 2021 17:16:10 +0100
>
>
>
>
> * guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
>   Make REPO a key.
> ---
> Looks like Martin forgot to update the Hackage importer in commit
> bea3b17739fc591b8cf6db1f8d28a6f6c9585577.
>
>  guix/import/hackage.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
> index 6ca4f65cb0..9f992ffe8e 100644
> --- a/guix/import/hackage.scm
> +++ b/guix/import/hackage.scm
> @@ -344,8 +344,8 @@ respectively."
>    (memoize hackage->guix-package))
>  
>  (define* (hackage-recursive-import package-name . args)
> -  (recursive-import package-name #f
> -                    #:repo->guix-package (lambda (name repo)
> +  (recursive-import package-name
> +                    #:repo->guix-package (lambda* (name #:key repo version)
>                                             (apply hackage->guix-package/m
>                                                    (cons name args)))
>                      #:guix-name hackage-name->package-name))
> -- 
> 2.30.0
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#46833: [PATCH v2] import: hackage: Accept optional version parameter.
>
>
>
>
> Date: 
>
> Mon, 01 Mar 2021 17:02:13 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hi,
>
> Xinglu Chen <public@yoctocell.xyz> skribis:
>
> > * guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
> >   Make REPO a key.
>
> Applied, thanks!
>
> Ludo’.
>
>
> --- End Message ---