bug#46715: closed ([PATCH] guix import: Fixing detection of Fortran files.)

[GNU bug Tracking System]

Your message dated Mon, 01 Mar 2021 22:47:46 +0100
with message-id <8735xebl6l.fsf@elephly.net>
and subject line Re: [PATCH] guix import: Fixing detection of Fortran files.
has caused the debbugs.gnu.org bug report #46715,
regarding [PATCH] guix import: Fixing detection of Fortran files.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46715: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46715
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] guix import: Fixing detection of Fortran files.
>
>
>
>
> Date: 
>
> Tue, 23 Feb 2021 12:00:21 +0100
>
>
>
>
> This fixes a bug whereby Guix importer considers files like .f.*
> being Fortran's files.
>
> (find-files dir "\\.f(90|95)?")
>
> would consider a lot of files with an extension starting with f
> being a Fortran file. The right way is to consider only files
> ending with .f90 or .f95.
>
> *guix/import/cran.scm: changing pattern of the detection for
> Fortran's files to .f(90|95)$.
>
> Co-authored-by: Ricardo Wurmus <rekado@elephly.net>
> ---
>  guix/import/cran.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/import/cran.scm b/guix/import/cran.scm
> index e8caf080fd..dbc858cb84 100644
> --- a/guix/import/cran.scm
> +++ b/guix/import/cran.scm
> @@ -361,7 +361,7 @@ empty list when the FIELD cannot be found."
>  
>  (define (directory-needs-fortran? dir)
>    "Check if the directory DIR contains Fortran source files."
> -  (match (find-files dir "\\.f(90|95)?")
> +  (match (find-files dir "\\.f(90|95)$")
>      (() #f)
>      (_ #t)))
>  
> -- 
> 2.30.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] guix import: Fixing detection of Fortran files.
>
>
>
>
> Date: 
>
> Mon, 01 Mar 2021 22:47:46 +0100
>
>
>
>
> User-agent: 
>
> mu4e 1.4.14; emacs 27.1
>
>
>
>
> Hi Mădălin,
>
> Thanks!  I applied this with a few changes in the commit message.
> (Commit 35814292b6.)
>
> -- 
> Ricardo
>
>
> --- End Message ---