--- Begin Message ---
Subject: |
[PATCH] gnu: Update bitcoin-core to 0.21.0 |
Date: |
Wed, 03 Feb 2021 02:54:30 +0000 |
In addition to updating, I made as well, separate `bitcoin-core-0.20` and
`bitcoin-core-0.21` packages.
Due to RPC changes, it is possible that other programs compatible with older
`bitcoin-core` version is not compatible with newer version.
Thus, an `operating-system` declaration, may need to pin a specific major
version.
Hoping for your kind review and acceptance of this patch.
Tested with `guix build bitcoin-core`.
Is there more testing I need to do before this is accepted?
Regards,
ZmnSCPxj
>From 319a66d931f2191ab91037e0ba9da1c2b969229d Mon Sep 17 00:00:00 2001
From: ZmnSCPxj <ZmnSCPxj@protonmail.com>
Date: Wed, 3 Feb 2021 00:51:07 +0000
Subject: [PATCH] gnu: Update bitcoin-core to 0.21.0
* gnu/packages/finance.scm (make-bitcoin-core): New procedure, moved from ...
(bitcoin-core): ... here. Update to 0.21.0.
(bitcoin-core-0.20): New variable.
(bitcoin-core-0.21): New variable.
---
gnu/packages/finance.scm | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 1798ad82bc..dc9b911c68 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -22,6 +22,7 @@
;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
;;; Copyright © 2020 Carlo Holl <carloholl@gmail.com>
;;; Copyright © 2020 Giacomo Leidi <goodoldpaul@autistici.org>
+;;; Copyright © 2021 ZmnSCPxj <ZmnSCPxj@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -108,18 +109,17 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages gnuzilla))
-(define-public bitcoin-core
+(define (make-bitcoin-core target-version hash)
(package
(name "bitcoin-core")
- (version "0.20.1")
+ (version target-version)
(source (origin
(method url-fetch)
(uri
(string-append "https://bitcoincore.org/bin/bitcoin-core-"
version "/bitcoin-" version ".tar.gz"))
(sha256
- (base32
- "0y5rad68b398arh0abr2wgiwybdw0i5a4dxz9s3fk9fgdbyn5gab"))))
+ (base32 hash))))
(build-system gnu-build-system)
(native-inputs
`(("autoconf" ,autoconf)
@@ -186,6 +186,14 @@ of the bitcoin protocol. This package provides the
Bitcoin Core command
line client and a client based on Qt.")
(license license:expat)))
+;; Pinning specific versions may be necessary due to changes in
+;; RPC interface, or signalling reasons.
+(define-public bitcoin-core-0.20
+ (make-bitcoin-core "0.20.1"
"0y5rad68b398arh0abr2wgiwybdw0i5a4dxz9s3fk9fgdbyn5gab"))
+(define-public bitcoin-core-0.21
+ (make-bitcoin-core "0.21.0"
"0dszcn4r43w0ffsmgwmyzkzr5lqws3bbhlkssmjgnjgfc8n2148s"))
+(define-public bitcoin-core bitcoin-core-0.21)
+
(define-public hledger
(package
(name "hledger")
--
2.30.0
--- End Message ---
--- Begin Message ---
Subject: |
Re: [PATCH v2] gnu: Update bitcoin-core to 0.21.0 |
Date: |
Tue, 23 Mar 2021 21:59:11 +0000 |
User-agent: |
mu4e 1.4.15; emacs 27.1 |
ZmnSCPxj <ZmnSCPxj@protonmail.com> writes:
> * gnu/packages/finance.scm (bitcoin-core): Update to 0.21.0.
> (bitcoin-core-0.20): New variable.
> (bitcoin-core-0.21): New variable.
> ---
> gnu/packages/finance.scm | 31 ++++++++++++++++++++++++++++---
> 1 file changed, 28 insertions(+), 3 deletions(-)
Thanks, I've gone ahead and upshed this as
d3c8aa3f8214434c8ba819984ed4513796a09e38. Sorry for the delay.
I tweaked one of the comments just to be a bit shorter, also tweaked the
commit message.
Thanks again,
Chris
signature.asc
Description: PGP signature
--- End Message ---