bug#33310: closed (Cuirass: Evaluations adding no new builds are displayed as "failing")

[GNU bug Tracking System]

Your message dated Thu, 25 Mar 2021 13:54:10 +0100
with message-id <87blb75r7x.fsf@gnu.org>
and subject line Re: bug#33310: Cuirass: Evaluations adding no new builds are 
displayed as "failing"
has caused the debbugs.gnu.org bug report #33310,
regarding Cuirass: Evaluations adding no new builds are displayed as "failing"
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
33310: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33310
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Cuirass: Evaluations adding no new builds are displayed as "failing"
>
>
>
>
> Date: 
>
> Thu, 08 Nov 2018 10:34:22 +0100
>
>
>
>
> User-agent: 
>
> mu4e 1.0; emacs 26.1
>
>
>
>
> Hi,
>
> Evaluations adding no new builds are displayed as "failing".  I know
> this was done on purpose, but I think the check should be done on the
> number of jobs returned by the evaluator, rather than on the number of
> builds registered in the database.
>
> There is a difference because derivations that are already in the
> database won't be added again.
>
> In my case (https://cuirass.lassieur.org/jobset/guix-manifest-clem), 70%
> of the evaluations add no new builds, and none of them are failing.
>
> --8<---------------cut here---------------start------------->8---
>     (with-store store
>       (let ((jobs (evaluate store spec eval-id checkouts)))
>         (log-message "building ~a jobs for '~a'"
>                      (length jobs) name)
>         (build-packages store jobs eval-id)))
> --8<---------------cut here---------------end--------------->8---
>
> Thus if (zero? (length jobs)) here, we should mark the corresponding
> evaluation as failing.
>
> Thanks,
> Clément
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#33310: Cuirass: Evaluations adding no new builds are displayed as "failing"
>
>
>
>
> Date: 
>
> Thu, 25 Mar 2021 13:54:10 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hello,
>
> Closing as this is fixed on Cuirass master.
>
> Thanks,
>
> Mathieu
>
>
> --- End Message ---