bug#51108: closed ([PATCH] import: pypi: Support 'input-changes'.)

[GNU bug Tracking System]

Your message dated Fri, 15 Oct 2021 23:22:07 +0200
with message-id <87czo6dlvk.fsf@gnu.org>
and subject line Re: bug#51108: [PATCH] import: pypi: Support 'input-changes'.
has caused the debbugs.gnu.org bug report #51108,
regarding [PATCH] import: pypi: Support 'input-changes'.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
51108: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51108
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] import: pypi: Support 'input-changes'.
>
>
>
>
> Date: 
>
> Sat, 09 Oct 2021 12:21:15 +0200
>
>
>
>
> * guix/import/pypi.scm (latest-release): Specify the ‘input-changes’ field.
> ---
>  guix/import/pypi.scm | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
> index b7859c8341..52835cf44d 100644
> --- a/guix/import/pypi.scm
> +++ b/guix/import/pypi.scm
> @@ -532,7 +532,8 @@ (define pypi-package?
>  (define (latest-release package)
>    "Return an <upstream-source> for the latest release of PACKAGE."
>    (let* ((pypi-name    (guix-package->pypi-name package))
> -         (pypi-package (pypi-fetch pypi-name)))
> +         (pypi-package (pypi-fetch pypi-name))
> +         (name (package-name package)))
>      (and pypi-package
>           (guard (c ((missing-source-error? c) #f))
>             (let* ((info    (pypi-project-info pypi-package))
> @@ -540,9 +541,12 @@ (define (latest-release package)
>                    (url     (distribution-url
>                              (latest-source-release pypi-package))))
>               (upstream-source
> -              (package (package-name package))
> +              (package name)
>                (version version)
> -              (urls (list url))))))))
> +              (urls (list url))
> +              (input-changes
> +               (changed-inputs name
> +                               (pypi->guix-package pypi-name)))))))))
>  
>  (define %pypi-updater
>    (upstream-updater
>
> base-commit: fd8ea9abf5b4ded096b7ccadb5e36fde4bac0867
> -- 
> 2.33.0
>
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#51108: [PATCH] import: pypi: Support 'input-changes'.
>
>
>
>
> Date: 
>
> Fri, 15 Oct 2021 23:22:07 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Xinglu Chen <public@yoctocell.xyz> skribis:
>
> > * guix/import/pypi.scm (latest-release): Specify the ‘input-changes’ field.
>
> [...]
>
> > +              (input-changes
> > +               (changed-inputs name
> > +                               (pypi->guix-package pypi-name)))))))))
>
> This was bogus (it passes the package name of instead of the package
> itself).  I fixed it and pushed as
> 50d2900e7621aed7aea99884b6d9b41c389167d9.  It works with:
>
>   ./pre-inst-env guix refresh python-notebook -u
>
> Let me know if anything’s amiss!
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---