emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50143: closed (28.0.50; Various issues with `tamil-itrans' input met


From: GNU bug Tracking System
Subject: bug#50143: closed (28.0.50; Various issues with `tamil-itrans' input method)
Date: Sun, 13 Mar 2022 08:24:02 +0000

Your message dated Sun, 13 Mar 2022 10:23:33 +0200
with message-id <83wngyl0qi.fsf@gnu.org>
and subject line Re: bug#50143: 28.0.50; Various issues with `tamil-itrans' 
input method
has caused the debbugs.gnu.org bug report #50143,
regarding 28.0.50; Various issues with `tamil-itrans' input method
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
50143: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50143
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 28.0.50; Various issues with `tamil-itrans' input method Date: Sat, 21 Aug 2021 14:55:23 +0530 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0
I am working on `tamil-phonetic.el`, a "Tamil Phonetic Input for
Emacs".  See https://github.com/rnchzn/tamil-phonetic and
https://raw.githubusercontent.com/rnchzn/tamil-phonetic/main/tamil-phonetic.el.
I will be submitting this library for inclusion in NON GNU ELPA.

In preparation for that step, I desire fixes for three issues listed
below.  Of these first two are bugs, and the last is an API
enhancement request.

1. The `indian-tml-base-table' has no entries for letters ௐ and ஶ.
   The fix for this would be to do this:

        (setcar (nthcdr (seq-position (nth 2 indian-itrans-v5-table-for-tamil) 
'("AUM" "OM")
                                      (lambda (s1 s2)
                                        (when (and (consp s1) (consp s2))
                                          (string= (car s1) (car s2)))))
                        (nth 2 indian-tml-base-table))
                ?ௐ)

        (setcar (nthcdr (seq-position (nth 1 indian-itrans-v5-table-for-tamil) 
"sh"
                                      (lambda (s1 s2)
                                        (when (and (stringp s1) (stringp s2))
                                          (string= s1 s2))))
                        (nth 1 indian-tml-base-table))
                ?ஶ)

   I have chosen entry for "sh" above because of the recommendations
   in the following link https://github.com/avinash311/itrans and 
   
https://docs.google.com/spreadsheets/d/14wZl8zCa4khZV3El2VGoqurKBLGx21mbS-yORi4w7Qo/edit#gid=0

   See the attached screenshot for relevant portions.

2. M-x describe-input-method RET tamil-itrans RET doesn't show the
   help table. i.e., instead of saying

   > Uses keymap ‘quail-tamil-itrans-syllable-table’, which is not currently 
defined.

   it should display the value of `quail-tamil-itrans-syllable-table'
   inline.

   The problem is the docstring uses "keymap" syntax, when in actual
   fact, that variable in NOT a keymap but a text with some display
   properties.

   There are two more such variables that have the same issues as
   above variable.
   
   See the attached screenshot.

3. `indian-make-hash` ALWAYS installs translation for decimal digits
   0-9.  Tamil decimal digits are NOT used at all i.e., it is not even
   taught in Schools in the state of TamilNadu, India.  So, I wanted a
   way NOT to insall the translation for digits.  I suggest one of the
   following:

   - Change signature of `(indian-make-hash TABLE TRANS-TABLE)' to
     `(indian-make-hash TABLE TRANS-TABLE &optional
     DONT-INSTALL-NATIVE-DIGITS)' or some such thing.
     
     `indian-make-hash' is used by many indic scripts, so I am not
     sure if other indian language users would have a need for
     inputting native decimal digits.  I--as a representative of Tamil
     speakers--can say that we don't need that ON by default.
    
   - Or provide a new API which honors looks at digits row of
     TRANS-TABLE and honor it.  This way the caller has more
     flexibility in installing mapping of his choice.



In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo 
version 1.16.0)
 of 2021-07-08 built on debian
Repository revision: 7d6d14023a4ad7907c6e10ebdb49d78f9c6393e4
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure -with-imagemagick --with-json --with-xwidgets'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2
M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS
TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB

Important settings:
  value of $LANG: en_IN
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: iso-latin-1-unix

Attachment: Screenshot from 2021-08-21 14-50-53.png
Description: PNG image

Attachment: Screenshot from 2021-08-21 14-17-22.png
Description: PNG image

Attachment: Screenshot from 2021-08-21 14-18-15.png
Description: PNG image


--- End Message ---
--- Begin Message --- Subject: Re: bug#50143: 28.0.50; Various issues with `tamil-itrans' input method Date: Sun, 13 Mar 2022 10:23:33 +0200
> From: Visuwesh <visuweshm@gmail.com>
> Cc: 50143@debbugs.gnu.org,  rameshnedunchezian@outlook.com
> Date: Sun, 13 Mar 2022 12:46:52 +0530
> 
> >>     1. There's still a problem with tamil-itrans docstring.  It
> >>        currently leads the user into thinking that they can input the
> >>        Tamil digits.  The problem is that I am not sure how I can split
> >>        `quail-tamil-itrans-various-signs-and-digits-table' into two
> >>        cleanly.  Ideas are welcome.
> >
> > I'd split into two parts the code that computes
> > quail-tamil-itrans-various-signs-and-digits-table, such that the Tamil
> > digits are in a separate part.  Then change the doc strings of the two
> > input methods so that the digits part is only included in the
> > documentation of the input method that supports their insertion.
> >
> 
> How does the updated patch look?

LGTM, installed.

> >>    2. The problem with the include variable syntax is because `quail-help'
> >>       (which is used eventually by `describe-input-method') calls
> >>       `substitute-command-keys' on the docstring so to get the intended
> >>       behaviour, one has to write \\=\\<VAR> not \\<VAR>.  The logic,
> >>       otherwise, is fine.  Maybe this needs to be documented?
> >
> > Yes, please.
> >
> 
> I tried to fix this, please see attached patch,

Thanks, installed.

> > Btw, the patch is already close to the limit of what we can accept
> > without copyright assignment, so would you like to start your legal
> > paperwork rolling at this time, so that we could in the future accept
> > more contributions from you?  If yes, I will send you the form to fill
> > and the instructions to go with that.
> >
> 
> BTW, I sent the mail to assign@gnu.org on 23rd Feb, and haven't heard
> from them yet.

Please send a reminder to them and CC me.  Thanks.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]