bug#56387: closed ([PATCH] computed-file: Clarify comment about guile record field.)

[GNU bug Tracking System]

Your message dated Thu, 07 Jul 2022 17:39:31 -0400
with message-id <87r12wvbzg.fsf@gmail.com>
and subject line Re: bug#56387: [PATCH] computed-file: Clarify comment about 
guile record field.
has caused the debbugs.gnu.org bug report #56387,
regarding [PATCH] computed-file: Clarify comment about guile record field.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
56387: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56387
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] computed-file: Clarify comment about guile record field.
>
>
>
>
> Date: 
>
> Mon,  4 Jul 2022 15:02:28 -0500
>
>
>
>
> * guix/gexp.scm (<computed-file>): Clarify that what goes in the guile
> record field is any variant of a guile package record instance.
> ---
>  guix/gexp.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/gexp.scm b/guix/gexp.scm
> index ef92223048..eba65e92cf 100644
> --- a/guix/gexp.scm
> +++ b/guix/gexp.scm
> @@ -581,7 +581,7 @@ (define-record-type <computed-file>
>    computed-file?
>    (name       computed-file-name)                 ;string
>    (gexp       computed-file-gexp)                 ;gexp
> -  (guile      computed-file-guile)                ;<package>
> +  (guile      computed-file-guile)                ;<package guile-*>
>    (options    computed-file-options))             ;list of arguments
>  
>  (define* (computed-file name gexp
> -- 
> 2.36.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#56387: [PATCH] computed-file: Clarify comment about guile record field.
>
>
>
>
> Date: 
>
> Thu, 07 Jul 2022 17:39:31 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hi jgart,
>
> jgart <jgart@dismail.de> writes:
>
> > * guix/gexp.scm (<computed-file>): Clarify that what goes in the guile
> > record field is any variant of a guile package record instance.
> > ---
> >  guix/gexp.scm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/guix/gexp.scm b/guix/gexp.scm
> > index ef92223048..eba65e92cf 100644
> > --- a/guix/gexp.scm
> > +++ b/guix/gexp.scm
> > @@ -581,7 +581,7 @@ (define-record-type <computed-file>
> >    computed-file?
> >    (name       computed-file-name)                 ;string
> >    (gexp       computed-file-gexp)                 ;gexp
> > -  (guile      computed-file-guile)                ;<package>
> > +  (guile      computed-file-guile)                ;<package guile-*>
> >    (options    computed-file-options))             ;list of arguments
>
> If this was a statically typed language, the proper type of the argument
> accepted would be <package>, not <package guile-*>, so I'm inclined to
> leave it the way it is (also, we'd have to survey the whole code base to
> adjust for our current convention, which is to use <package>).
>
> Closing,
>
> Thanks,
>
> Maxim
>
>
> --- End Message ---