emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#56364: closed ([PATCH] gnu: Add glymur)


From: GNU bug Tracking System
Subject: bug#56364: closed ([PATCH] gnu: Add glymur)
Date: Fri, 08 Jul 2022 21:58:02 +0000

Your message dated Fri, 08 Jul 2022 23:57:04 +0200
with message-id <874jzrs1xr.fsf@gnu.org>
and subject line Re: bug#56364: [PATCH] gnu: Add glymur
has caused the debbugs.gnu.org bug report #56364,
regarding [PATCH] gnu: Add glymur
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
56364: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56364
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] gnu: Add glymur Date: Sat, 2 Jul 2022 21:34:33 +0100
Hi Guix team!

This package contains Python interface to OpenJEPEG and LibTIFF which
requires some tweaks to let it find system library.

It's goes as one of the SunPy dependence I've started packing.

> ./pre-inst-env guix build python-glymur --rounds=2 --check
successfully built
/gnu/store/r77vwchzhhfi40xlmffwxyjpa4x8wxzv-python-glymur-0.10.1.drv
successfully built
/gnu/store/r77vwchzhhfi40xlmffwxyjpa4x8wxzv-python-glymur-0.10.1.drv
/gnu/store/nx10j711hps4glkxfw17gx0np1wnz1vh-python-glymur-0.10.1

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

Attachment: 0001-gnu-Add-glymur.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#56364: [PATCH] gnu: Add glymur Date: Fri, 08 Jul 2022 23:57:04 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
Hi,

Sharlatan Hellseher <sharlatanus@gmail.com> skribis:

> From 776f0ce0a22c83809d9a3dc4752180580e3632df Mon Sep 17 00:00:00 2001
> From: Sharlatan Hellseher <sharlatanus@gmail.com>
> Date: Sat, 2 Jul 2022 21:28:39 +0100
> Subject: [PATCH] gnu: Add glymur
>
> * gnu/packages/python-xyz.scm (python-glymur): New variable.

Applied with the changes below: in this case ‘search-input-file’ is an
improvement IMO because it ensures that the file you’re looking for
(“libopenjp2.so”, etc.) actually exists.  Also it allows us to refer to
the ‘glibc’ package that implicitly provided rather than add a
dependency on an extra ‘glibc’ variant.

Thanks!

Ludo’.

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 76491631ae..3f4867ece0 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -931,7 +931,7 @@ (define-public python-glymur
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'patch-library-locations
-            (lambda _
+            (lambda* (#:key inputs #:allow-other-keys)
               ;; XXX: It's a workaround for Python inability to find the
               ;; .so libraries with ctypes.util.find_library()
               (substitute* '("glymur/config.py")
@@ -939,13 +939,13 @@ (define-public python-glymur
                  (string-append
                   "if libname == \"openjp2\":\n"
                   "        path = \""
-                  #$(this-package-input "openjpeg") "/lib/libopenjp2.so\"\n"
+                  (search-input-file inputs "/lib/libopenjp2.so") "\"\n"
                   "    elif libname == \"tiff\":\n"
                   "        path = \""
-                  #$(this-package-input "libtiff") "/lib/libtiff.so\"\n"
+                  (search-input-file inputs "/lib/libtiff.so") "\"\n"
                   "    elif libname == \"c\":\n"
                   "        path = \""
-                  #$(this-package-input "glibc") "/lib/libc.so.6\"\n")))))
+                  (search-input-file inputs "/lib/libc.so.6") "\"\n")))))
           ;; TODO: implement as a feature of python-build-system (PEP-621,
           ;; PEP-631, PEP-660)
           (replace 'build
@@ -971,8 +971,7 @@ (define-public python-glymur
      (list python-pypa-build python-pytest))
     (inputs
      (list openjpeg  ; glymur/lib/openjp2.py
-           libtiff   ; glymur/lib/tiff.py
-           glibc))
+           libtiff)) ; glymur/lib/tiff.py
     (propagated-inputs
      (list python-lxml
            python-numpy

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]