bug#38432: closed (dockerd is not started automatically)

[GNU bug Tracking System]

Your message dated Wed, 13 Jul 2022 21:40:53 -0400
with message-id <877d4g1nfe.fsf@gmail.com>
and subject line Re: bug#55936: dockerd fails to start on boot
has caused the debbugs.gnu.org bug report #55936,
regarding dockerd is not started automatically
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
55936: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55936
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> dockerd is not started automatically
>
>
>
>
> Date: 
>
> Fri, 29 Nov 2019 22:06:10 +0000
>
>
>
>
> User-agent: 
>
> Mutt/1.12.1 (2019-06-15)
>
>
>
>
> When defined in /etc/config.scm as the manual suggests[1]
> >    (service docker-service-type)
>
> dockerd is not started with other services.
> It could be started manually by
> $ herd start dockerd
>
> [1] https://guix.gnu.org/manual/en/html_node/Miscellaneous-Services.html
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#55936: dockerd fails to start on boot
>
>
>
>
> Date: 
>
> Wed, 13 Jul 2022 21:40:53 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hi Oleg,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
> > Hi,
> >
> > Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> >
> >> Hi Oleg,
> >>
> >> Oleg Pykhalov <go.wigust@gmail.com> writes:
> >>
> >>> Fixes <https://issues.guix.gnu.org/38432>.
> >>>
> >>> * gnu/packages/patches/containerd-create-pid-file.patch: New file.
> >>> * gnu/local.mk (dist_patch_DATA): Add this.
> >>> * gnu/packages/docker.scm (containerd)[source]: Add this patch.
> >>> * gnu/services/docker.scm
> >>> (containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout.
> >>> * gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag.
> >>
> >> Thanks for this, it looks promising!
>
> [...]
>
> > All that to say that I shall be reviewing your patches shortly :-).
>
> Now done; it all looks good to me!  I've run the docker system test, and
> installed it on my machine, rebooted, confirmed it was up, restarted
> containerd a couple times and checked the PID content matched its actual
> PID, and it seems to behave as expected!
>
> Pushed as b33e1a183f6756514e6b6a3b84054a232dbddad4.
>
> Thank you!
>
> Maxim
>
>
> --- End Message ---