--- Begin Message ---
|
Subject: |
[PATCH 8/9] gnu: Add node-crx3. |
|
Date: |
Tue, 14 Jun 2022 11:49:53 +0200 |
* gnu/packages/node-xyz.scm (node-crx3): New variable.
---
gnu/packages/node-xyz.scm | 40 +++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 8ec014eee8..79594856f1 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -109,6 +109,46 @@ (define-public node-color-name
"This package provides a JSON list with color names and their values.")
(license license:expat)))
+(define-public node-crx3
+ (package
+ (name "node-crx3")
+ (version "1.1.3")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ahwayakchih/crx3";)
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1snqyw8c3s9p2clhqh1172z0rs1was36sfxkk6acgpar32c2rwzw"))))
+ (build-system node-build-system)
+ (arguments
+ '(#:phases
+ (modify-phases %standard-phases
+ (delete 'check)
+ (add-after 'unpack 'replace-mri-by-minimist
+ (lambda _
+ (substitute* "package.json"
+ (("\"mri\": \"\\^1.1.6\",") "\"minimist\": \"^1.2.6\","))
+ (substitute* "lib/configuration.js"
+ (("mri") "minimist"))
+ #t))
+ (replace 'configure
+ (lambda* (#:key inputs #:allow-other-keys)
+ (invoke (string-append (assoc-ref inputs "node") "/bin/npm")
+ "--offline" "--ignore-scripts" "install" "--production")
+ #t)))))
+ (inputs (list node-minimist node-pbf node-yazl))
+ (home-page "https://github.com/ahwayakchih/crx3";)
+ (synopsis "Create web extension files for Chromium and all other browsers
+supporting the file format and API")
+ (description "This package creates web extension files (CRXv3) for Chromium
+versions 64.0.3242 and above and all other browsers supporting the file format
+and API.")
+ (license license:bsd-3)))
+
(define-public node-env-variable
(package
(name "node-env-variable")
--
2.36.1
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: Updated series |
|
Date: |
Wed, 20 Jul 2022 17:16:48 +0200 |
Nicolas Graves <ngraves@ngraves.fr> skriver:
> Hi Marius,
>
> Sorry for the time it took me, here's the updated series.
No worries, thanks a lot for this work.
> Everything has been checked with guix lint. I use emacs, but couldn't get guix
> style to work the way you counselled, hope it's ok.
What was the issue? :-)
I ran 'guix style' for each since I had to edit the commits anyway to
get the author right (for some reason it showed up as "Nicolas Graves
via Guix-patches <guix-patches@gnu.org>" -- NYF!).
> Also thanks for your advice!
:-)
Some more advice for future pull requests, please first send a message
to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything,
although often a 'git format-patch --cover-letter'). Then send the
patch series to NNNNN@debbugs.gnu.org, otherwise the patches will
be scattered across different issues and difficult to track.
Also, use "-n" with send-email/format-patch so that the ordering is
preserved. It was lacking in the second series, but I used the
information from the first round to get it right.
Anyway, great work, pushed as c8f33b613e..cda3de3b7d!
signature.asc
Description: PGP signature
--- End Message ---