emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#57482: closed ([PATCH] gnu: Add emacs-org-fc.)


From: GNU bug Tracking System
Subject: bug#57482: closed ([PATCH] gnu: Add emacs-org-fc.)
Date: Sat, 03 Sep 2022 08:14:03 +0000

Your message dated Sat, 03 Sep 2022 10:12:55 +0200
with message-id <87fsh8vptk.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#57482] [PATCH] gnu: Add emacs-org-fc.
has caused the debbugs.gnu.org bug report #57482,
regarding [PATCH] gnu: Add emacs-org-fc.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57482: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57482
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] gnu: Add emacs-org-fc. Date: Tue, 30 Aug 2022 14:32:13 +0800
From: 宋文武 <iyzsong@member.fsf.org>

* gnu/packages/emacs-xyz.scm (emacs-org-fc): New variable.
---
 gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 90ee485f1e..90d817527b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -166,6 +166,7 @@ (define-module (gnu packages emacs-xyz)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages games)
+  #:use-module (gnu packages gawk)
   #:use-module (gnu packages golang)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gtk)
@@ -32410,3 +32411,46 @@ (define-public emacs-vertico-posframe
 a Vertico extension which provides a way to pop up a frame at point to show
 a vertical completion UI.")
     (license license:gpl3+)))
+
+(define-public emacs-org-fc
+  (let ((commit "f64b5336485a42be91cfe77850c02a41575f5984")
+        (revision "0"))
+    (package
+      (name "emacs-org-fc")
+      (version (git-version "0.1.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://git.sr.ht/~l3kn/org-fc";)
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1d0a3vr09zkplclypcgpfbfd6r0h0i3g3zsqb4pcz6x239d59gd5"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-hydra))
+      (inputs (list findutils gawk))
+      (arguments
+       (list
+        #:include #~(list "\\.el$" "\\.awk$" "\\.org$")
+        #:exclude #~(list "^tests/")
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'qualify-paths
+              (lambda* (#:key inputs #:allow-other-keys)
+                (let ((find (search-input-file inputs "/bin/find"))
+                      (gawk (search-input-file inputs "/bin/gawk"))
+                      (xargs (search-input-file inputs "/bin/xargs")))
+                  (substitute* "org-fc-awk.el"
+                    (("\"find ") (string-append "\"" find " "))
+                    (("\"gawk ") (string-append "\"" gawk " "))
+                    (("\"xargs ") (string-append "\"" xargs " ")))))))))
+      (home-page "https://www.leonrische.me/fc/index.html";)
+      (synopsis "Spaced Repetition System for Emacs org-mode")
+      (description
+       "Org-fc is a spaced-repetition system for Emacs' org-mode.
+It allows you to mark headlines in a file as flashcards, turning pieces of
+knowledge you want to learn into a question-answer test.  These cards are
+reviewed at regular interval.  After each review, the next review interval is
+calculated based on how well you remembered the contents of the card.")
+      (license license:gpl3+))))
-- 
2.37.2




--- End Message ---
--- Begin Message --- Subject: Re: [bug#57482] [PATCH] gnu: Add emacs-org-fc. Date: Sat, 03 Sep 2022 10:12:55 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
Hello,

iyzsong--- via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-fc): New variable.

I applied your patch with the changes below. Thank you.

> +      (arguments
> +       (list
> +        #:include #~(list "\\.el$" "\\.awk$" "\\.org$")

I used  #~(cons* ... %default-include) instead.

> +        #:exclude #~(list "^tests/")

Likewise, I used #~(cons ... %default-exclude)

> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (add-after 'unpack 'qualify-paths
> +              (lambda* (#:key inputs #:allow-other-keys)
> +                (let ((find (search-input-file inputs "/bin/find"))
> +                      (gawk (search-input-file inputs "/bin/gawk"))
> +                      (xargs (search-input-file inputs "/bin/xargs")))
> +                  (substitute* "org-fc-awk.el"
> +                    (("\"find ") (string-append "\"" find " "))
> +                    (("\"gawk ") (string-append "\"" gawk " "))
> +                    (("\"xargs ") (string-append "\"" xargs " ")))))))))


I also activated check phase.

> +      (home-page "https://www.leonrische.me/fc/index.html";)
> +      (synopsis "Spaced Repetition System for Emacs org-mode")

I removed over-capitalization. Also (nitpick), I replaced org-mode with
Org mode.

> +      (description
> +       "Org-fc is a spaced-repetition system for Emacs' org-mode.

Ditto.

Regards,
-- 
Nicolas Goaziou


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]