bug#52022: closed ([PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is.)

[GNU bug Tracking System]

Your message dated Fri, 09 Sep 2022 18:19:02 +0200
with message-id <db5c2c1f74f91b2176af575f1820e91c044d53df.camel@gmail.com>
and subject line Re: [PATCH] gnu: gst-plugins/selection: Fix behaviour when 
using flags as-is.
has caused the debbugs.gnu.org bug report #52022,
regarding [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags 
as-is.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
52022: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52022
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is.
>
>
>
>
> Date: 
>
> Sun, 21 Nov 2021 18:41:28 +0100
>
>
>
>
> When using this gst-plugins/selection without setting configure-flags, the
> existing flags are simply inherited.  This leads to an issue with
> unquote-splicing when looking at quoted lists, e.g. as used by
> gst-plugins-bad.
>
> * gnu/packages/gstreamer.scm (gst-plugins-selection)[#:configure-flags]:
> Only splice user-provided configure-flags, simply unquote those from existing
> packages.
>
> Reported-by: unmatched-paren, nckx (IRC)
> ---
>  gnu/packages/gstreamer.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
> index 2927055240..f7d0808b98 100644
> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm
> @@ -924,13 +924,15 @@ (define-public gst-plugins/selection
>      (package/inherit pkg
>        (arguments
>         (substitute-keyword-arguments (package-arguments pkg)
> -         ((#:configure-flags flags `(,@(or configure-flags '())))
> +         ((#:configure-flags flags ''())
>            `(append
>              (list
>               ,@(map (lambda (plugin)
>                        (string-append "-D" plugin "=enabled"))
>                      plugins))
> -            (list ,@(or configure-flags flags))))
> +            ,(if configure-flags
> +                 `(list ,@configure-flags)
> +                 flags)))
>            ((#:phases phases)
>             `(modify-phases ,phases
>                (add-after 'unpack 'disable-auto-plugins
> -- 
> 2.34.0
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is.
>
>
>
>
> Date: 
>
> Fri, 09 Sep 2022 18:19:02 +0200
>
>
>
>
> User-agent: 
>
> Evolution 3.42.1 
>
>
>
>
> Am Sonntag, dem 21.11.2021 um 18:41 +0100 schrieb Liliana Marie
> Prikler:
> > When using this gst-plugins/selection without setting configure-
> > flags, the
> > existing flags are simply inherited.  This leads to an issue with
> > unquote-splicing when looking at quoted lists, e.g. as used by
> > gst-plugins-bad.
> > 
> > * gnu/packages/gstreamer.scm (gst-plugins-selection)[#:configure-
> > flags]:
> > Only splice user-provided configure-flags, simply unquote those from
> > existing
> > packages.
> > 
> > Reported-by: unmatched-paren, nckx (IRC)
> This patch appears rather outdated and has been superseded by one I
> applied to staging.  Thus closing.
>
>
> --- End Message ---