bug#57691: closed (29.0.50; image-tests failures)

[GNU bug Tracking System]

Your message dated Tue, 13 Sep 2022 15:05:54 +0300
with message-id <83sfkv4gyl.fsf@gnu.org>
and subject line Re: bug#57691: 29.0.50; image-tests failures
has caused the debbugs.gnu.org bug report #57691,
regarding 29.0.50; image-tests failures
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57691: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57691
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 29.0.50; image-tests failures
>
>
>
>
> Date: 
>
> Fri, 09 Sep 2022 09:26:18 +0300
>
>
>
>
> Running test/manual/image-tests.el, as in
>
>   ./src/emacs -Q -l test/manual/image-tests.el --eval "(ert t)"
>
> produces 2 failures:
>
> Selector: t
> Passed:  38
> Failed:  2 (2 unexpected)
> Skipped: 0
> Total:   40/40
>
> Started at:   2022-09-09 09:22:13+0300
> Finished.
> Finished at:  2022-09-09 09:22:19+0300
>
> ..........F........................F....
>
> F image-tests-image-metadata/gif
>     (ert-test-failed
>      ((should
>        (memq 'delay
>               (image-metadata
>                (create-image ...))))
>       :form
>       (memq delay nil)
>       :value nil))
>
> F image-tests-load-image/svg-invalid
>     (ert-test-failed
>      ((should
>        (string-search "XML parse error"
>                       (buffer-string)))
>       :form
>       (string-search "XML parse error" "For information about GNU Emacs and the 
> GNU system, type C-h C-a.\nType C-c C-c to view the image as text\nError 
> parsing SVG image: Error domain 1 code 4 on line 1 column 1 of data: Start tag 
> expected, '<' not found [3 times]\n")
>       :value nil))
>
> Let me know if I can help in debugging this.
>
> In GNU Emacs 29.0.50 (build 1848, i686-pc-mingw32) of 2022-09-09 built
>  on HOME-C4E4A596F7
> Repository revision: adc8344e759b0aa3c919df9bdff1232d89b2e6b4
> Repository branch: master
> Windowing system distributor 'Microsoft Corp.', version 5.1.2600
> System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600)
>
> Configured using:
>  'configure -C --prefix=/d/usr --with-wide-int
>  --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3''
>
> Configured features:
> ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY
> W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
> TOOLKIT_SCROLL_BARS WEBP XPM ZLIB
>
> Important settings:
>   value of $LANG: ENU
>   locale-coding-system: cp1255
>
> Major mode: Lisp Interaction
>
> Minor modes in effect:
>   tooltip-mode: t
>   global-eldoc-mode: t
>   eldoc-mode: t
>   show-paren-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   tool-bar-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   line-number-mode: t
>   indent-tabs-mode: t
>   transient-mark-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr emacsbug message mailcap yank-media puny dired
> dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
> epg-config gnus-util text-property-search time-date subr-x mm-decode
> mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
> cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
> mail-prsvr mail-utils rmc iso-transl tooltip eldoc paren electric
> uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32
> ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win
> tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
> newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
> rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
> font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq
> simple cl-generic indonesian philippine cham georgian utf-8-lang
> misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
> cp51932 hebrew greek romanian slovak czech european ethiopic indian
> cyrillic chinese composite emoji-zwj charscript charprop case-table
> epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
> loaddefs faces cus-face macroexp files window text-properties overlay
> sha1 md5 base64 format env code-pages mule custom widget keymap
> hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty
> make-network-process emacs)
>
> Memory information:
> ((conses 16 42423 9500)
>  (symbols 48 6244 0)
>  (strings 16 16532 2998)
>  (string-bytes 1 397900)
>  (vectors 16 9231)
>  (vector-slots 8 144103 13397)
>  (floats 8 23 45)
>  (intervals 40 274 97)
>  (buffers 896 10))
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#57691: 29.0.50; image-tests failures
>
>
>
>
> Date: 
>
> Tue, 13 Sep 2022 15:05:54 +0300
>
>
>
>
> > From: Stefan Kangas <stefankangas@gmail.com>
> > Date: Tue, 13 Sep 2022 05:40:00 -0400
> > Cc: 57691@debbugs.gnu.org
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > >> This should now be done on master.  Could you please test?
> > >
> > > Thanks, but the condition is wrong, so it still fails.  The test is
> > > skipped unless either one of two conditions hold, and the first one
> > > does hold even if w32-use-native-image-API is non-nil.
> > 
> > Well, that was a brain fart.  Should be fixed now.
>
> Thanks, it works now.
>
>
> --- End Message ---