--- Begin Message ---
|
Subject: |
[PATCH 0/1] Support for importing a specified version of a gem. |
|
Date: |
Fri, 9 Sep 2022 22:44:33 +0900 |
Hi,
I've improved the guix gem importer. We can import a specific version gem by
this patch.
Hopefully, I'd like to improve gem-recursive-import so that become can import
specific version dependencies.
To do so, we need to implement a parser for the gem version string and a
resolver to fetch the latest gem of the version range. (such as the go
importer)
It may be difficult for me, but I'll try later.
However, this patch is not perfect, but I think that still useful.
I recognize that I should modify the documentation, but I'm not good at
English, so could you modify the documentation if you need it?
Regard,
Taiju HIGASHI (1):
import: gem: Support for importing a specified version of a gem.
guix/import/gem.scm | 19 ++++--
guix/scripts/import/gem.scm | 39 +++++++------
tests/gem.scm | 113 ++++++++++++++++++++++++++++++++++++
3 files changed, 148 insertions(+), 23 deletions(-)
--
2.37.2
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [PATCH 1/1] import: gem: Support for importing a specified version of a gem. |
|
Date: |
Sat, 17 Sep 2022 19:18:41 +0200 |
|
User-agent: |
mu4e 1.8.9; emacs 28.1 |
Taiju HIGASHI <higashi@taiju.info> writes:
> Hi Chris,
>
> Could you give me your opinion on this patch?
> Is this patch worth it?
Hey,
Unfortunately I haven't had much time to look at Ruby stuff recently,
but these changes look good to me. I tweaked a few minor things and
pushed this as c967d1153cae419e4acbe0dbed8f558d95ced0e3.
Thanks,
Chris
> Taiju HIGASHI <higashi@taiju.info> writes:
>
>> * guix/import/gem.scm: (rubygems-fetch, gem->guix-package)
>> (gem-recursive-import): Fix to fetch the specified version of the gem.
>> * guix/scripts/import/gem.scm (show-help): Modify the help message.
>> (guix-import-gem): Modify the version number to be passed to subsequent
>> procedures
>> * tests/gem.scm: Add tests.
>> ---
>> guix/import/gem.scm | 19 ++++--
>> guix/scripts/import/gem.scm | 39 +++++++------
>> tests/gem.scm | 113 ++++++++++++++++++++++++++++++++++++
>> 3 files changed, 148 insertions(+), 23 deletions(-)
signature.asc
Description: PGP signature
--- End Message ---