bug#57870: closed (27.1; vc-tor has no effect)

[GNU bug Tracking System]

Your message dated Sat, 17 Sep 2022 18:01:46 -0700
with message-id <87mtax7ax1.fsf@melete.silentflame.com>
and subject line Re: bug#57870: 27.1; vc-tor has no effect
has caused the debbugs.gnu.org bug report #57870,
regarding 27.1; vc-tor has no effect
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57870: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57870
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 27.1; vc-tor has no effect Date: Fri, 16 Sep 2022 16:22:04 -0700 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Hello,

>From reading vc-do-command, it looks to me that the vc-tor defcustom has
never actually had any effect on the commands that are run.  The
full-command variable is used only in messages displayed to the user.

If someone else could verify this, I'll push the attached.  This is
blocking my work on #57807.  Thanks.

-- 
Sean Whitton

0001-vc-do-command-Actually-include-torsocks-in-the-comma.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#57870: 27.1; vc-tor has no effect
>
>
>
>
> Date: 
>
> Sat, 17 Sep 2022 18:01:46 -0700
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
>
>
>
>
> Hello,
>
> On Sat 17 Sep 2022 at 02:28PM GMT, Philip Kaludercic wrote:
>
> > Sean Whitton <spwhitton@spwhitton.name> writes:
> >
> >> Hello,
> >>
> >>>From reading vc-do-command, it looks to me that the vc-tor defcustom has
> >> never actually had any effect on the commands that are run.  The
> >> full-command variable is used only in messages displayed to the user.
> >>
> >> If someone else could verify this, I'll push the attached.  This is
> >> blocking my work on #57807.  Thanks.
> >
> > I've just tried it out and it seems to do the right thing.
>
> Thanks for reviewing!
>
> -- 
> Sean Whitton
>
>
> --- End Message ---