bug#57253: closed ([PATCH] gnu: Add keychain.)

[GNU bug Tracking System]

Your message dated Thu, 22 Sep 2022 10:00:57 +0200
with message-id <20220922100057.5d6c170a@alma-ubu.fritz.box>
and subject line Re: [bug#57253] [PATCH 2/2] gnu: Add keychain.
has caused the debbugs.gnu.org bug report #57253,
regarding [PATCH] gnu: Add keychain.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57253: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57253
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 1/2] gnu: greybird-gtk-theme: Build with librsvg-for-system.
>
>
>
>
> Date: 
>
> Wed, 17 Aug 2022 01:46:01 +0200
>
>
>
>
> * gnu/packages/gnome-xyz.scm (greybird-gtk-theme)[inputs]:
>   Replace librsvg with librsvg-for-system.
> ---
>  gnu/packages/gnome-xyz.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> index c37ae27cc5..beab5429bf 100644
> --- a/gnu/packages/gnome-xyz.scm
> +++ b/gnu/packages/gnome-xyz.scm
> @@ -18,6 +18,7 @@
>  ;;; Copyright © 2021 Charles Jackson <charles.b.jackson@protonmail.com>
>  ;;; Copyright © 2022 Eric Bavier <bavier@posteo.net>
>  ;;; Copyright © 2022 Sughosha <sughosha@proton.me>
> +;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1137,7 +1138,7 @@ (define-public greybird-gtk-theme
>      (native-inputs
>       (list gtk+
>             `(,glib "bin") ; for "glib-compile-resources"
> -           librsvg
> +           (librsvg-for-system)
>             pkg-config
>             ruby-sass
>             sassc))
>
> base-commit: 8aab1f7c73c3a6e204b1257e687120c009c88604
> -- 
> 2.37.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#57253] [PATCH 2/2] gnu: Add keychain. Date: Thu, 22 Sep 2022 10:00:57 +0200

On Wed, 21 Sep 2022 23:52:54 +0200
Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> wrote:

> The reason might be related to the fact that I sent two unrelated
> patches in the same serie (I'm unsure how best to send unrelated
> patches).


OK. I reviewed it and pushed under

da3bbcc9916b08324e7b85f5b9c528b4696c39d4

with some slight changes:

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 3553415ad5..074fa5bf31 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -47,7 +47,6 @@ (define-module (gnu packages crypto)
   #:use-module (gnu packages aidc)
   #:use-module (gnu packages attr)
   #:use-module (gnu packages autotools)
-  #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -1716,9 +1715,9 @@ (define-public keychain
                (base32
                 "1bkjlg0a2bbdjhwp37ci1rwikvrl4s3xlbf2jq2z4azc96dr83mj"))))
     (build-system gnu-build-system)
-    (native-inputs (list bash))
+    (propagated-inputs (list procps))
     (arguments
-     `(#:tests? #f
+     `(#:tests? #f ; No test suite
        #:phases (modify-phases %standard-phases
                   (delete 'configure)
                   (replace 'install

* There is no need to use/import bash
* ps is required to find the agent, so I propagated procps
* Tests disabled because there are none. Commented about that fact.

Thanks,

Björn

pgpqALYgF6uMq.pgp
Description: OpenPGP digital signature

--- End Message ---