bug#58057: closed ([PATCH] gnu: Add emacs-macrostep-geiser.)

[GNU bug Tracking System]

Your message dated Sun, 25 Sep 2022 15:22:07 +0200
with message-id <87mtantwqo.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#58057] [PATCH] gnu: Add emacs-macrostep-geiser.
has caused the debbugs.gnu.org bug report #58057,
regarding [PATCH] gnu: Add emacs-macrostep-geiser.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58057: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58057
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add emacs-macrostep-geiser.
>
>
>
>
> Date: 
>
> Sun, 25 Sep 2022 09:16:47 +0800
>
>
>
>
> * gnu/packages/emacs-xyz.scm (emacs-macrostep-geiser): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index d324b39af3..9df7dcd1c6 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -20612,6 +20612,29 @@ (define-public emacs-macrostep
>  expansions for debugging with Edebug as normal.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-macrostep-geiser
> +  (let ((commit "f6a2d5bb96ade4f23df557649af87ebd0cc45125")
> +        (revision "1"))
> +    (package
> +      (name "emacs-macrostep-geiser")
> +      (version (git-version "0.2.0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/nbfalcon/macrostep-geiser";)
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "0dykvwcvg8n24z3fkx6rv3l1mhzmca4cxj0gsvvqsg9wp0az1fc7"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs (list emacs-macrostep emacs-geiser))
> +      (home-page "https://github.com/nbfalcon/macrostep-geiser";)
> +      (synopsis "macrostep for geiser and cider")
> +      (description
> +       "This plug-in implements a macrostep back-end powered by geiser.")
> +      (license license:gpl3+))))
> +
>  (define-public emacs-parent-mode
>    (package
>      (name "emacs-parent-mode")
> -- 
> 2.37.3
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#58057] [PATCH] gnu: Add emacs-macrostep-geiser.
>
>
>
>
> Date: 
>
> Sun, 25 Sep 2022 15:22:07 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hello,
>
> Hilton Chain via Guix-patches via <guix-patches@gnu.org> writes:
>
> > * gnu/packages/emacs-xyz.scm (emacs-macrostep-geiser): New variable.
>
> Thank you. I applied the patch with the following changes:
>
> > +(define-public emacs-macrostep-geiser
> > +  (let ((commit "f6a2d5bb96ade4f23df557649af87ebd0cc45125")
> > +        (revision "1"))
> > +    (package
> > +      (name "emacs-macrostep-geiser")
> > +      (version (git-version "0.2.0" revision commit))
>
> I downgraded the commit used to the one matching the version bump. As
> a consequence, version is exactly "0.2.0", which is always nicer when
> subsequent changes do not bring much to the table.
>
> > +      (propagated-inputs (list emacs-macrostep emacs-geiser))
>
> I ordered inputs alphabetically.
>
> > +      (synopsis "macrostep for geiser and cider")
> > +      (description
> > +       "This plug-in implements a macrostep back-end powered by geiser.")
>
> I used capitalization for Macrostep and Geiser.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---