bug#57809: closed ([PATCH] gnome-boxes: Add 'qemu' as propagated-input)

[GNU bug Tracking System]

Your message dated Mon, 26 Sep 2022 23:03:21 +0200
with message-id <87v8p9j1ba.fsf_-_@gnu.org>
and subject line Re: bug#57809: [PATCH] gnome-boxes: Add 'qemu' as 
propagated-input
has caused the debbugs.gnu.org bug report #57809,
regarding [PATCH] gnome-boxes: Add 'qemu' as propagated-input
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57809: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57809
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnome-boxes: Add 'qemu' as propagated-input Date: Wed, 14 Sep 2022 18:17:48 +0000

Fixes:

(gnome-boxes:9304): Boxes-WARNING **: 19:54:29.345: review-page.vala:32: Box 
setup failed: Failed to create volume: internal error: creation of non-raw file 
images is not supported without qemu-img.

(gnome-boxes:9304): Boxes-CRITICAL **: 19:54:29.345: 
boxes_assistant_review_page_populate: assertion 'machine != NULL' failed

Steps to reproduce:
1. Open gnome-boxes on GNU Guix
2. Try to create a box with GNU Guix ISO and expect failure above

publickey - kreyren@rixotstudio.cz - 1677db82.asc
Description: application/pgp-keys

signature.asc
Description: OpenPGP digital signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#57809: [PATCH] gnome-boxes: Add 'qemu' as propagated-input
>
>
>
>
> Date: 
>
> Mon, 26 Sep 2022 23:03:21 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hi,
>
> Jacob Hrbek <kreyren@rixotstudio.cz> skribis:
>
> > ---
> >  gnu/packages/gnome.scm | 12 +++++++++---
> >  1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> > index d6d22f8eb1..ff5cb92907 100644
> > --- a/gnu/packages/gnome.scm
> > +++ b/gnu/packages/gnome.scm
> > @@ -12131,9 +12131,14 @@ (define-public gnome-boxes
> >                                                      #$output
> >                                                      "/lib/gnome-boxes"))
> >             #:phases #~(modify-phases %standard-phases
> > -                        (add-after 'unpack 'disable-gtk-update-icon-cache
> > -                          (lambda _
> > -                            (setenv "DESTDIR" "/"))))))
> > +                      (add-after 'unpack 'disable-gtk-update-icon-cache
> > +                        (lambda _
> > +                          (setenv "DESTDIR" "/")))
> > +                      (add-before 'configure 'substitute-qemu-dependencies
> > +                        (lambda* (#:key inputs #:allow-other-keys)
> > +
> >                 (substitute* "src/installed-media.vala"
> > +                              (("qemu-img")
> > +                               (search-input-file inputs 
> > "/bin/qemu-img"))))))))
>
> Applied with minor tweaks and a commit log, thanks!|
>
> Ludo’.
>
>
> --- End Message ---