bug#58165: closed ([Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks)

[GNU bug Tracking System]

Your message dated Fri, 30 Sep 2022 11:24:23 +0000
with message-id <87a66hxfyw.fsf@posteo.net>
and subject line Re: bug#58165: [Patch] [GNU ELPA] rcirc-color: Allow 
recoloring nicks
has caused the debbugs.gnu.org bug report #58165,
regarding [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58165: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58165
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks Date: Thu, 29 Sep 2022 16:58:21 +0200

I think rcirc-color should allow a nick to be "recolored" with the
command `/color nick', instead of signalling an error as it does now.

This is useful, for example, when two similar nicks are assigned the
same color but there's no specific color you want to reassign to either
of them.

0001-rcirc-color-Select-a-random-color-on-color-nick.patch
Description: The patch

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#58165: [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks
>
>
>
>
> Date: 
>
> Fri, 30 Sep 2022 11:24:23 +0000
>
>
>
>
> Thuna <thuna.cing@gmail.com> writes:
>
> >> While at it one could replace the `foreground-color', since (elisp)
> >> Special Properties says:
> >>
> >>         • A cons cell of the form ‘(foreground-color . COLOR-NAME)’ or
> >>           ‘(background-color . COLOR-NAME)’.  This specifies the
> >>           foreground or background color, similar to ‘(:foreground
> >>           COLOR-NAME)’ or ‘(:background COLOR-NAME)’.  This form is
> >>           supported for backward compatibility only, and should be
> >>           avoided.
> >
> > I avoided it on the off chance something would break, but I don't mind
> > either way.
>
> I think I can do this.
>
> >> Also, it would be nice to also reformat the code using a let* block.
> >> Something like
> >>
> >>         (let* ((index (random (length rcirc-colors)))
> >>                (color (elt rcirc-colors index))
> >>                (face (cons 'foreground-color color)))
> >>           (puthash nick face rcirc-color-mapping))
> >
> > Seems ok to me.
>
> I'll pull your patch and make this change in a subsequent commit.
>
> So thank you for the patch.
>
>
> --- End Message ---