bug#63541: closed ([PATCH] ; Fix use-package :vc keyword when byte-compiled)

[GNU bug Tracking System]

Your message dated Sat, 03 Jun 2023 10:28:51 +0300
with message-id <837csl9f7w.fsf@gnu.org>
and subject line Re: bug#63541: [PATCH] ; Fix use-package :vc keyword when 
byte-compiled
has caused the debbugs.gnu.org bug report #63541,
regarding [PATCH] ; Fix use-package :vc keyword when byte-compiled
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63541: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63541
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] ; Fix use-package :vc keyword when byte-compiled
>
>
>
>
> Date: 
>
> Tue, 16 May 2023 16:12:04 -0700
>
>
>
>
> * lisp/use-package/use-package-core.el (use-package-handler/:vc):
> Return the new 'body'. Otherwise, the entire package declaration gets
> dropped when byte-compiling.
> ---
>  lisp/use-package/use-package-core.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/use-package/use-package-core.el 
> b/lisp/use-package/use-package-core.el
> index 0d99e270a3f..e0e16134ed3 100644
> --- a/lisp/use-package/use-package-core.el
> +++ b/lisp/use-package/use-package-core.el
> @@ -1619,7 +1619,8 @@ defvar use-package--form)
>      ;; See `use-package-handler/:ensure' for an explanation.
>      (if (bound-and-true-p byte-compile-current-file)
>          (funcall #'use-package-vc-install arg local-path)        ; compile time
> -      (push `(use-package-vc-install ',arg ,local-path) body)))) ; runtime
> +      (push `(use-package-vc-install ',arg ,local-path) body))   ; runtime
> +    body))
>  
>  (defun use-package-normalize--vc-arg (arg)
>    "Normalize possible arguments to the `:vc' keyword.
> -- 
> 2.40.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled
>
>
>
>
> Date: 
>
> Sat, 03 Jun 2023 10:28:51 +0300
>
>
>
>
> > From: Philip Kaludercic <philipk@posteo.net>
> > Cc: Steven Allen <steven@stebalien.com>,  soliditsallgood@mailbox.org,
> >   63541@debbugs.gnu.org
> > Date: Wed, 31 May 2023 21:53:41 +0000
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > >> Cc: 63541@debbugs.gnu.org
> > >> From: Steven Allen <steven@stebalien.com>
> > >> Date: Thu, 25 May 2023 21:54:29 -0700
> > >> 
> > >> Here's a version of the patch with a test.
> > >
> > > Philip, should I install this?
> > 
> > I don't value my own input, since this is related to use-package which I
> > do not use, but from a general intuition it looks fine.
>
> Thanks for the feedback.  I've now installed this on the master
> branch, and I'm closing the bug.
>
>
> --- End Message ---