bug#61977: closed ([PATCH] channels: Raise an error if dependency's introduction is malformed)

[GNU bug Tracking System]

Your message dated Sun, 04 Jun 2023 11:38:55 +0200
with message-id <87fs77efdc.fsf@jpoiret.xyz>
and subject line Re: [PATCH] channels: Raise an error if dependency's 
introduction is malformed
has caused the debbugs.gnu.org bug report #61977,
regarding [PATCH] channels: Raise an error if dependency's introduction is 
malformed
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61977: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61977
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] channels: Raise an error if dependency's introduction is malformed
>
>
>
>
> Date: 
>
> Sun,  5 Mar 2023 11:56:09 +0100
>
>
>
>
> * guix/channels.scm (sexp->channel-introduction): Do it.
> ---
>  guix/channels.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/guix/channels.scm b/guix/channels.scm
> index d44e7a0a3a..fc2bf55d65 100644
> --- a/guix/channels.scm
> +++ b/guix/channels.scm
> @@ -256,7 +256,14 @@ (define sexp->channel-introduction
>                              ('commit commit) ('signer signer)
>                              _ ...)
>       (make-channel-introduction commit (openpgp-fingerprint signer)))
> -    (x #f)))
> +    (x (raise (condition
> +               (&message
> +                (message (format #f "channel dependency has an invalid\
> + introduction field")))
> +               (&error-location
> +                (location
> +                 (source-properties->location
> +                  (source-properties x)))))))))
>  
>  (define (read-channel-metadata port)
>    "Read from PORT channel metadata in the format expected for the
>
> base-commit: 2799ad44234be675f018115f99be98d2c9fd565d
> -- 
> 2.39.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH] channels: Raise an error if dependency's introduction is malformed Date: Sun, 04 Jun 2023 11:38:55 +0200

Hi everyone,

Josselin Poiret <dev@jpoiret.xyz> writes:

> * guix/channels.scm (sexp->channel-introduction): Do it.

Pushed as cacc0cb6ab22218a3783a51ba9986405ede4e0d8, with Simon's
suggestion of adding G_.

Best,
-- 
Josselin Poiret

signature.asc
Description: PGP signature

--- End Message ---