bug#63720: closed ([PATCH] website: List languages in two columns.)

[GNU bug Tracking System]

Your message dated Tue, 06 Jun 2023 08:29:18 +0200
with message-id <877cshw1c1.fsf@pelzflorian.de>
and subject line Re: bug#63720: [PATCH] website: List languages in two columns.
has caused the debbugs.gnu.org bug report #63720,
regarding [PATCH] website: List languages in two columns.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63720: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63720
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] website: List languages in two columns.
>
>
>
>
> Date: 
>
> Thu, 25 May 2023 17:41:45 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> * website/apps/base/templates/components.scm (navbar): Specify a CSS
> class for the languages dropdown list.
> * website/static/base/css/navbar.css (languages-dropdown-list): New
> rule.
> ---
>
> The translations dropdown is too long and high.  It seems to me
> adjusting the number of columns dynamically and limiting the height is
> not possible, unless we rewrite dropdowns to use CSS flexbox in <div>
> elements instead of lists.  Instead, this patch sets a fixed column
> number of two, which should be appropriate for the foreseeable future.
>
> Also, there is only one languages dropdown, so this patch could
> specify an id and not a new class for the languages dropdown.  But a
> class works too and works always, so using a class seems better (?).
>
>  website/apps/base/templates/components.scm | 3 ++-
>  website/static/base/css/navbar.css         | 3 +++
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/website/apps/base/templates/components.scm 
> b/website/apps/base/templates/components.scm
> index 5f4af9c..241c27e 100644
> --- a/website/apps/base/templates/components.scm
> +++ b/website/apps/base/templates/components.scm
> @@ -1,5 +1,5 @@
>  ;;; GNU Guix web site
> -;;; Copyright © 2019 Florian Pelz <pelzflorian@pelzflorian.de>
> +;;; Copyright © 2019, 2023 Florian Pelz <pelzflorian@pelzflorian.de>
>  ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
>  ;;; Initially written by sirgazil who waives all
>  ;;; copyright interest on this file.
> @@ -501,6 +501,7 @@ manual.
>        ,(menu-dropdown #:label (locale-display-name) #:active-item active-item
>          #:items
>          (append
> +          (list '(@ (class "languages-dropdown-list")))
>            (map-in-order
>             (lambda (ietf-info)
>               (let ((lingua (car ietf-info))
> diff --git a/website/static/base/css/navbar.css 
> b/website/static/base/css/navbar.css
> index 974516a..c2dce90 100644
> --- a/website/static/base/css/navbar.css
> +++ b/website/static/base/css/navbar.css
> @@ -117,6 +117,9 @@ label.menu-item {
>      display: none;
>  }
>  
> +.languages-dropdown-list {
> +    columns: 2;
> +}
>  
>  
>  
>
> base-commit: c4df5a59a97bce391e1be68dd8b4c1107cce4b23
> -- 
> 2.39.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#63720: [PATCH] website: List languages in two columns.
>
>
>
>
> Date: 
>
> Tue, 06 Jun 2023 08:29:18 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Pushed as a076562297db72b45ac82f7627a23e4be615d558.
>
> Thank you Ludo for confirming the columns number.
>
> Regards,
> Florian
>
>
> --- End Message ---