--- Begin Message ---
|
Subject: |
[PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. |
|
Date: |
Mon, 05 Jun 2023 13:50:02 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello,
I think this patch is self-explanatory. In order to get the ding you
have to "(setopt completion-auto-help 'visible)" and try to complete
something successfully. I was doing 'M-x eshell-command-mo <TAB>' to
complete the symbol eshell-command-mode.
I'm not sure if that's actually the complete minimal setup, but I don't
think you guys have to bother reproducing it since it's pretty obvious
my patch is an improvement.
0001-lisp-minibuffer.el-minibuffer-completion-help-Only-d.patch
Description: Text Data
Thanks,
Morgan
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. |
|
Date: |
Sat, 10 Jun 2023 12:13:04 +0300 |
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Morgan Smith <Morgan.J.Smith@outlook.com>, Jimmy Aguilar Mena
> <spacibba@aol.com>, 63913@debbugs.gnu.org
> Date: Thu, 08 Jun 2023 12:54:37 -0400
>
> > I've added to the discussion folks that know more about this than I
> > do. Stefan, Ergus: any comments to the issue or about the proposed
> > patch? (I'm not sure we need to change the message when we do "ding",
> > but that's a separate issue, I think.)
>
> The patch looks good to me. Thank you, Morgan.
Thanks, installed on the emacs-29 branch, and closing the bug.
--- End Message ---