bug#64034: closed ([PATCH] libparted: link libparted-fs-resize.so to libuuid)

[GNU bug Tracking System]

Your message dated Tue, 13 Jun 2023 13:00:08 -0700
with message-id <ZIjKyHbdMnb6En1R@ohop.brianlane.com>
and subject line Re: bug#64034: [PATCH] libparted: link libparted-fs-resize.so 
to libuuid
has caused the debbugs.gnu.org bug report #64034,
regarding [PATCH] libparted: link libparted-fs-resize.so to libuuid
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
64034: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64034
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] libparted: link libparted-fs-resize.so to libuuid
>
>
>
>
> Date: 
>
> Mon, 12 Jun 2023 10:55:19 -0700
>
>
>
>
> uuid_generate() is used in this library
> Hence, add UUID_LIBS to libparted_fs_resize_la_LIBADD to avoid
>
> "ld.lld: error: undefined reference due to --no-allow-shlib-undefined: 
> uuid_generate"
>
> This is uncovered by lld linker linking fatresize package
> due to this linker defaulting to --no-allow-shlib-undefined.
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  libparted/fs/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libparted/fs/Makefile.am b/libparted/fs/Makefile.am
> index 41a60d9..7fa8d14 100644
> --- a/libparted/fs/Makefile.am
> +++ b/libparted/fs/Makefile.am
> @@ -75,6 +75,7 @@ libparted_fs_resize_la_LDFLAGS =              \
>  EXTRA_DIST += fsresize.sym
>  libparted_fs_resize_la_DEPENDENCIES = $(sym_file)
>  
> +libparted_fs_resize_la_LIBADD  = $(UUID_LIBS)
>  libparted_fs_resize_la_SOURCES = \
>    r/filesys.c                  \
>    r/fat/bootsector.c           \
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#64034: [PATCH] libparted: link libparted-fs-resize.so to libuuid
>
>
>
>
> Date: 
>
> Tue, 13 Jun 2023 13:00:08 -0700
>
>
>
>
> On Mon, Jun 12, 2023 at 10:55:19AM -0700, Khem Raj wrote:
> > uuid_generate() is used in this library
> > Hence, add UUID_LIBS to libparted_fs_resize_la_LIBADD to avoid
> > 
> > "ld.lld: error: undefined reference due to --no-allow-shlib-undefined: 
> > uuid_generate"
> > 
> > This is uncovered by lld linker linking fatresize package
> > due to this linker defaulting to --no-allow-shlib-undefined.
>
> Thanks! Merged into master.
>
> Brian
>
> -- 
> Brian C. Lane (PST8PDT) - weldr.io - lorax - parted - pykickstart
>
>
>
> --- End Message ---